Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ChevronRight icon component and its corresponding export index file. The review feedback suggests improving the component's implementation by utilizing the color prop from IconProps as a fallback for the SVG fill to ensure consistency with the interface, and adding a missing trailing newline to the source file.
|
@kishore08-07 Hey can u review it once plz before merging |
ITACHI161105
force-pushed
the
feat/add-chevron-right-icon
branch
from
ffe42e5 to
d389c0a
Compare
The meshmap package legitimately relies on peer-dep relaxation (e.g. jquery@^4 × cytoscape-clipboard), matching its own install:legacy-peer-deps script. Without this flag the bump job fails with ERESOLVE on npm install, matching the bump-layer5 job which already uses --legacy-peer-deps. Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
ITACHI161105
force-pushed
the
feat/add-chevron-right-icon
branch
from
e13ccc4 to
0967b29
Compare
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
ITACHI161105
force-pushed
the
feat/add-chevron-right-icon
branch
from
9349c09 to
f42e419
Compare
ITACHI161105
left a comment
ITACHI161105
left a comment
There was a problem hiding this comment.
"Addressed all review comments — added DEFAULT_FILL_NONE to imports, removed ONYX_BLACK, and updated the default fill and JSX accordingly."
|
Thanks @ITACHI161105 |
kishore08-07
left a comment
kishore08-07
left a comment
There was a problem hiding this comment.
@ITACHI161105
Take this https://github.com/layer5io/sistent/pull/1324/changes as reference template and refactor the changes accordingly.
There was a problem hiding this comment.
@ITACHI161105 Could you please revert this change? It appears to be out of scope for this PR.
4 participants
Closes #1415
Added ChevronRight icon following the same pattern as ChevronLeft icon.