Skip to content

[fix] ActionButton: Align dropdown menu to button group - #1810

Open
MAYANKSHARMA01010 wants to merge 1 commit into
layer5io:masterfrom
MAYANKSHARMA01010:fix/actionbutton-dropdown-alignment
Open

[fix] ActionButton: Align dropdown menu to button group#1810
MAYANKSHARMA01010 wants to merge 1 commit into
layer5io:masterfrom
MAYANKSHARMA01010:fix/actionbutton-dropdown-alignment

Conversation

@MAYANKSHARMA01010

Copy link
Copy Markdown

Notes for Reviewers

This PR fixes #1809
Related Meshery Issue: meshery/meshery#21450

Description:

  • Replaced dynamic anchorEl state with a stable anchorRef attached to <ButtonGroup>.
  • Configured <Popper> to anchor to anchorRef.current with placement="bottom-start" for consistent dropdown alignment.
  • Added toggle fallback on the primary button when defaultActionClick is not provided.
  • Added disabled?: boolean support to the Option interface and passed it to MenuItem.
  • Added unit test suite in src/__testing__/ActionButton.test.tsx.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Mayank Sharma <sharmamayank01010@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 13 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ebcdf1d-66e8-44ea-8057-cd3e502b1689

📥 Commits

Reviewing files that changed from the base of the PR and between 1dd6141 and 600e8c6.

📒 Files selected for processing (2)
  • src/__testing__/ActionButton.test.tsx
  • src/custom/ActionButton/ActionButton.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ActionButton: Dropdown menu misaligned when clicking dropdown arrow

1 participant