Repository navigation
feat(telescope): add a published picture to a page as one more dataset - #1298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
telescope new-object --from-esa PAGE_ID=PICTURE_URLdrafts a Hubble or Webb picture as one more dataset of a page that shows a shaped layer bank; the spec then writes the bank and bakes it. It reads the picture's page and sky tags and finds its star; a person writes the sentences and what each color takes. Run on the three dataset banks already here, it remakes them with every layer image identical. Guide.Those banks' registration sentences change: the tags' reference pixel is counted as FITS counts it, so the tags put the star 0.10″, 0.04″ and 0.26″ away, not 0.13″, 0.21″ and 0.29″. Nothing drawn depends on it.
Also fixed: in the Local Group the two Magellanic Clouds were covered by 2,714 cluster dots of the structures field. The field no longer holds them, so each Cloud is a dot in its diamond. README.
Limits: pictures ESA publishes, on pages that already show a shaped bank. The Clouds' billboard sprites, one step closer in, are as they were.
Prepared assets
inventory.json; no baked files.Clean: the generator's, lineage and package-consistency tests, typecheck and lint, hash, spelling, reference, growth and published-assets checks.
PR rules.