docs(architecture): propose the target layout of site/ for sign-off - #1301
Merged
Merged
Conversation
…efuse site production imports of tests
…s, checked by the projection
…ry so partial clones can run it
…ned/enforced the plan status
apresmoi
force-pushed
the
untangle7/s2-site-architecture
branch
from
October 5, 2026 08:04
5242813 to
2b15cb4
Compare
apresmoi
marked this pull request as ready for review
October 5, 2026 08:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The layout plan for
site/: eleven sibling layers, eachsite/folder assigned one. The owner decided the loader composition (option 3: the router starts at module evaluation and all loading goes through the single queue chain, exactly today's behaviour). No application file moves in this PR.docs/site-architecture.md: layers, move map summary, the code changes S3 must make (seven atomic groups, in order), the S4 sequence, risks. Its tables are generated from the data below.docs/site-architecture/{moves,tiers,edits,references}.json: the data (289 moved paths, graph edits, the reference inventory)..github/scripts/architecture/: import declarations by kind, the projection (cycles, upward, lateral and denied edges per kind, after moves and edits), and the plan checks (acceptance, identity, sequence, minimality, generated tables, reference scan).pnpm check:architectureruns the plan check with statusplanned(findings warn) until the plan is switched toenforced.production-imports-no-tests:site/production code may not import tests, fixtures or helpers.After the moves and edits the projection finds 0 cycles and 0 upward, lateral and denied edges in every view, and 0 unassigned files.
Checks
node --test .github/scripts/architecture/*.test.mts: 156 pass.site-architecture.mts --accept,--identity,--sequence,--minimality: pass.pnpm check:architecture: ARCHITECTURE_OK..github/scripts/architecture: pass.Follows the PR rules.