Repository navigation
perf: small bodies keep the dataset they left, bodies draw on one mesh at one atlas size, and picture layers decode before they show - #1330
Merged
Conversation
…its dataset pool states a byte budget of two selections
alowpoly
added
the
pipeline-change
…ces a frame instead of all in one commit
alowpoly
changed the title
…frame the body showed triangle holes while it assembled
…ists again; on its own the change measured no gain
alowpoly
changed the title
… longer swap in a second mesh cut from the same shape
alowpoly
changed the title
…ze; picking a dataset no longer swaps the mesh
alowpoly
changed the title
# Conflicts: # src/objects/sun/inventory.json
…photograph keeps its own shape; comet 67P has one mesh now
…drawn on the body's mesh
… an image bank's opacity stops just under 1
…ank's opacity stops under 1
alowpoly
changed the title
alowpoly
changed the title
alowpoly
changed the title
… size; two Tethys datasets no longer freeze an iPad's page
# Conflicts: # src/objects/sun/inventory.json
…celadus, Dione and Rhea get image-sized boxes
… datasets; picking it took 568 to 613 ms on an iPad, now 51 to 68
# Conflicts: # packages/renderer/src/image-layers/prepared-image-layer-runtime.test.ts # packages/renderer/src/image-layers/prepared-image-layer-runtime.ts # packages/renderer/src/universe/universe-catalog-banks.test.ts # site/build/prepare/prepare-object-json.mts # src/objects/observable-universe/inventory.json
…t pick froze an iPad's page for 5 to 13 seconds, now 223 to 353 ms
alowpoly
enabled auto-merge
October 5, 2026 19:16
alowpoly
disabled auto-merge
October 5, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Small bodies keep the images of the dataset they left. Guide.
A dataset takes its own mesh only when it is another shape; a body's datasets share one atlas size. One mesh: Mathilde, comet 67P, Bennu. One atlas size: Phoebe, Tethys, Mimas, Vesta, Enceladus. Smaller atlases: Deimos, Phobos. Datasets of Phoebe, Tethys and Deimos no longer freeze an iPad's page. Rules.
Enceladus, Dione and Rhea get the image-sized face boxes other globes have; the bake had missed them.
A nebula's layer stack decodes its images before it shows.
Evidence and limits
Proves the change: iPad, longest frame of a dataset switch: Bennu 345-349 to 74-78 ms; comet 67P 487-1,153 to 202-236; Phoebe 729-947 to 200-210; Tethys 733-1,008 to 139-142; Mimas 346-398 to 89-94; Vesta's geology 293-335 to 75-76; Enceladus 189-613 to 50-85; Deimos 5,010-13,227 to 223-353; Phobos 312-552 to 166-187. NGC 2392 turn 235 to 31, switch 270 to 30; M33 zoom 220 to 91. iPad screenshots after each switch show whole bodies.
Clean: typecheck, the bake's and the renderer's tests, the bodies' presentation audits.
Limits: Deimos keeps 1/4 of its atlas pixels, Phobos 9/16. After main's Eta Carinae change a bank of patches draws at full opacity: Cassiopeia A's zoom has a 276 ms frame (162 before this PR), not measured on main alone. 32.1 to 33.5% of a 67P VIRTIS atlas stays gridded; 67P's install grows 20 MB. The Helix's turns are 72 to 104 ms (82, 40, 38 before). No phone measured.