Repository navigation
refactor(world)!: the world's source and full context move from the Sun's package to the root object - #1337
Merged
Conversation
…un's package to the root object
…actor/world-files-to-root # Conflicts: # src/objects/sun/inventory.json
…actor/world-files-to-root
…actor/world-files-to-root # Conflicts: # .github/site-refactor.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sun's package held the world's source and its 58.7 MB full context, files that belong to no one body. Both move to the root object,
observable-universe, beside the world summary and index. The world step reads and writes them by rule, with no paths on its command line. Tools and tests that read the full context point at the root. No page reads these files, and nothing a page reads changes. Root README.Pixelmatch at threshold 0 against
main, four pages at their opening view (Sun, Solar System, Earth, Betelgeuse): 0 on all four in two of three captures. In the first capture after a server restart the Sun's page differs by 67 pixels inside one sidebar thumbnail; this branch captured again differs from that capture by the same 67.maincaptured three times: 0.Limits: opening views only; a wheel pull-back is not pixel-repeatable (
mainagainstmain: 475 to 1,308). The dot banks of 8 galaxies still name the Sun's old path; correcting it changes their bytes.Clean: typecheck, eslint, architecture, ownership, no-hashes, body references, package test lane. Site lane: 8 tests in 3 untouched files fail locally, as before; they pass in CI.
PR rules: titles, PDS4 provenance and ISO plain language.