feat(stars): add Eta Carinae inside the Homunculus Nebula - #1343
Merged
Merged
Conversation
… the nearest view
# Conflicts: # src/objects/sun/inventory.json
… loads under node
# Conflicts: # src/objects/sun/inventory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eta Carinae is now an object inside the Homunculus Nebula. A zoom in on the nebula goes on into the star with no click, and the star's page keeps the nebula's surface around it. What is drawn is its wind: a sphere out to where the near-infrared light is a tenth of the centre's (6 AU, VLTI), dimmed toward the edge to the measured half-brightness size, colored as a 9,400 K black body. README.
Turning the camera inside a nebula no longer blinks: the same drag had 15 one-step jumps of the picture inside the Homunculus, now 1 (a patch the camera passes through), and 4 to 6 inside NGC 2392, now none; at the Homunculus's nearest view 6, now none. Headless Chrome only.
Limits: the limb's exponent is fitted to two printed sizes; the halo is not drawn. The zoom in hands over at the nebula's nearest view, at rest (NGC 2392 leads to HD 59088 too). Around a body the patches cost about 0.5 ms more a frame. NGC 2392's sheets paint in an order set by rule; it matches the browser's sort to the pixel once the sheet the browser left out is hidden. Safari not measured.
Prepared assets
inventory.json.Clean: generator, navigation and renderer tests, typecheck, lint and the repository checks.
PR rules.