Repository navigation
refactor(site): move the dependency-closed set of site files into their owner folders - #1344
Merged
Merged
Conversation
… the move declaration as plan input
apresmoi
force-pushed
the
untangle7/s4-1-moves
branch
from
October 5, 2026 18:31
5794993 to
023ac79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
apply-moves.mts(75 source files and 114 tests), using the map in.github/site-refactor.json. Root files insite/: 187 to 98 in total, 118 to 59 without tests.site/moves too or already lives in a folder, and nothing the rest of the plan edits is moved.new URL(...)literals, globs,tsconfig, eslint,package.jsonscripts, workflows,ci-areas.json, the coverage ratchet floors (each floor follows its file), docs links and code spans were rewritten by the codemod and the old-path reference gate (site-architecture.mts --references --old): 0 live old-path references remain.../to../../), a glob indot-catalogue-data, fixtures that build temporary checkouts now create the new folders, and the audit workflow's test glob namessite/browser/source-link.test.mts.moves.jsonloses the applied entries,tiers.jsonfollows its test and asset paths, the tables are regenerated. Two small tool changes: fixtures under anysite/**/fixtures/count as test helpers for the nebula boundary check, and the move declaration counts as plan input for the reference gate.site/object-shell.cssandsite/components/ObjectSwatchStyles.astro: the build writes their path into every page (data-object-style="..."), so moving them changes HTML and server answers.site/startup-world.mts(and what imports it): the server-side bundle keeps its relativenew URL('../src/...')literal.site/diagnostic-recorder.mts,site/selection-presentation.mts,site/destination-browser.mts,site/feature-browser.mtsand the two selection files: a root file keeps importing them, which would close a folder cycle the baseline does not record..d.mtsstand-ins and the generatedsite/prepared-*files, which move with their producers later.pnpm test:siteruns 1,777 tests: 1,746 pass, 30 skipped, 0 failures; the one timeout under load (ci-speed.test.mts, new from perf(ci): per-package compiled cache, test shards, single generator pass #1345) passes alone, 6 of 6. The executed set maps one to one through the move map.Checks
Local comparison lane against main 8fe5f3a (production
ASSET_ORIGINbuilds, one shared base build; CI does not run the lane):Other checks:
pnpm typecheck:shell,typecheck:tests,typecheck:scripts,typecheck:ownership, eslint onsite,.github/scriptsand the touched entry points.pnpm check:architecture(baseline unchanged),site-architecture.mts --accept,--sequence,--minimality, 218 architecture, ratchet and move-tool tests,check-stale-references,check-documentation-links.Follows the pull request rules.