fix(universe): beyond the Local Group scale a galaxy is named, not a star or a galaxy inside it - #1349
Merged
Conversation
…star or a galaxy inside it on the same pixels
…nd the Local Group scale
alowpoly
enabled auto-merge
October 5, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zooming out through the Local Group, M 31, M 33, NGC 300 and NGC 253 had no caption: a featured star inside each outranks a galaxy and held its circle. Between galaxies the id decided, so the LMC was named over the Milky Way and M110 over M 31. Now, more than 300 kpc from the camera, a star, black hole or galaxy within the circle of a galaxy that holds it is not a caption candidate. The rule is
withinHolderin world-context-planner.ts, stated in universe-labels.md.Proves the change: captions while wheeling out of
/local-group/from 5.3 to 20 Mly (10 steps), headless Chrome. Before: a dev server whose renderer matchesmain. After: this branch's build.The new case in
world-context-planner.test.tsfails without the rule. On/virgo-cluster/five star captions become their galaxies';/m31/and/m87/keep theirs.Clean: renderer tests (774),
prepared-world-context.test.ts(115), renderer typechecks, eslint.Limits: dots are decided as before; the M87* dot test leaves M87 unnamed, since a named M87 covers its dot. Not run on other engines, the iPad or rendered-page suites. No image.
PR rules: titles, PDS4 provenance and ISO plain language.