refactor(model): move the held address reader out of navigation history - #1350
Merged
Merged
Conversation
apresmoi
force-pushed
the
untangle7/s3-1-held-address
branch
from
October 5, 2026 20:59
8cb55ee to
2f0faca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
navigationHrefand its owner registry) now lives insite/model/navigation-href.mts. Navigation history registers its reader there and re-exports the getter, so existing callers are unchanged..github/site-refactor.jsondeclares the change withlayout: "changes".manualChunkswas tried and made layout and bytes worse, so the plain move ships.Per-route bytes against main (all 15 measured routes show the same figures per route shape; client JS astro gzip 368634 to 368570):
/,/earth/,/dione/Total loaded is the first-view closure plus the lazily loaded closure. No route's first view or total grows by more than 0.5%.
Checks
pnpm check:architecture,pnpm typecheck, eslint on the touched files.site/model/navigation-href.test.mts,site/test/navigation-history.test.mts,site/application-world-resources.characterization.test.mts(16 pass).PR rules