fix(universe): on a nebula's page a body inside it is named in white over a dark grey copy of its name - #1356
Merged
Merged
Conversation
…rey copy of its name, so it reads on the picture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A star inside a nebula is named over the nebula's picture, in its own color at 65%, lost on its bright parts. On the nebula's own page the name is now white at full strength over a
#404040copy of the same text, one pixel down and right: the name painted twice, with no stroke, shadow or blend. The circle and the name's side are unchanged. A body is marked while the nebula that holds it is selected (prepared-world-context.ts); rules in world-context.css, stated in universe-labels.md. Today that is HD 59088 (NGC 2392) and Eta Carinae (Homunculus Nebula).Proves the change: share of the name's glyph pixels at WCAG 3:1 or better, Chrome with GPU. Before is the same page with the mark removed, as
maindraws it.Clean:
prepared-world-context.test.ts(116), renderer tests (775), typechecks, eslint,check-no-variables.On the Milky Way page all 24 names, these two included, are drawn at 65% as before.
Limits: not run on other engines or the iPad. No image.
PR rules: titles, PDS4 provenance and ISO plain language.