Repository navigation
fix: the ZIP restore that failed main, the Zenodo survey's question size, and lettered-star spellings - #1360
Merged
Merged
Conversation
…me; Zenodo refuses 20 or more in one question
…ember was pinned empty when unzip finished first, which failed main's CI
… K limit the code has
…d matches planets of lettered stars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes, one of them for a failure this session put on
main.mainsince feat(exoplanets): WASP-94 A b opens on its published climate model, read from a NetCDF-4 release #1357). The streamedzip-memberstep pinned an empty file whenunzipfinished before the write began to read it: Node discards a finished child's unread output. Its output is now piped on at once. Reproduced locally: 0 bytes read late, all 22 bytes when piped at once.mainsince feat(stars): add the central stars of the Ring, Owl, Helix and Southern Ring nebulae #1352). The test still expected the 40,000 K refusal; the code says 250,000 K.Proves the change: measured on 5 October 2026 over 110 questions: every one of up to 33 spellings was answered, every one of 44 or more refused. The fixed survey, live, over all 896 exoplanets of the tree: 70 questions, 71 requests, 201 s, no failure, 26 planets with records, WASP-94 A b and TOI-1259 A b among them.
Limits: Zenodo documents no limit, so 32 is a measured size.
Clean:
operations-acquisition,new-object-cli,simulation-dataset,simulations,leadsandpublished-map-datasettests; ESLint on changed files.PR rules.