Repository navigation
fix(earth): show the polar caps again; a leftover selector hid them with the cutaway - #1361
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Earth's two polar caps were not drawn: looking down on a pole showed a hole in the globe. #1300 removed the stylesheet rules that set the surface and pole images and left the first selector line of the pole rule,
.earth-body-polar > s,, behind. That line joined the next rule, the cutaway'sdisplay: none; visibility: hidden, so both caps were hidden. This deletes that one line from earth-surfaces.css. Only Earth changes.Evidence and limits
Proves the change: on the Earth page of a local dev server, both
.earth-polar-surfaceelements computeddisplay: none; visibility: hiddenbefore, with their image (earth-surface-poles-level-1024.webp) loaded. After the change they computedisplay: block; visibility: visible, with boxes of 108 × 57 px and 117 × 37 px in the default view.Clean:
node .github/scripts/checks/check-no-variables.mts.Limits: measured in one desktop Chromium at the default view. No test was added, and no other body's stylesheet was checked for the same leftover.
PR rules: titles, PDS4 provenance and ISO plain language.