Skip to content

Fix Deploy#725

Merged
lbedner merged 1 commit into
mainfrom
fix-deploy
Jun 7, 2026
Merged

Fix Deploy#725
lbedner merged 1 commit into
mainfrom
fix-deploy

Conversation

@lbedner

@lbedner lbedner commented Jun 7, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 7, 2026 19:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes rolling deploy behavior by ensuring docker-rollout is invoked with an explicit healthcheck timeout, preventing premature rollbacks caused by docker-rollout’s default 60s ceiling. It also surfaces the timeout as a CLI option and updates localized CLI/help strings accordingly.

Changes:

  • Add ROLLING_ROLLOUT_TIMEOUT_DEFAULT and a --rollout-timeout option, and pass -t to docker rollout during rolling deploys.
  • Factor the rollout shell command into _rolling_rollout_command() (with proper deploy path quoting) and cover it with unit tests.
  • Update i18n strings across all supported locales to reflect the timeout and add help text for the new option.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
aegis/commands/deploy.py Adds configurable rollout timeout, uses docker rollout -t, and centralizes command construction in a helper.
tests/cli/test_deploy_helpers.py Adds regression tests for the rollout command composition and default timeout constant.
aegis/i18n/locales/en.py Updates rolling deploy messaging to include {seconds} and adds help text for --rollout-timeout.
aegis/i18n/locales/de.py Same i18n updates for German.
aegis/i18n/locales/es.py Same i18n updates for Spanish.
aegis/i18n/locales/fr.py Same i18n updates for French.
aegis/i18n/locales/ja.py Same i18n updates for Japanese.
aegis/i18n/locales/ko.py Same i18n updates for Korean.
aegis/i18n/locales/ru.py Same i18n updates for Russian.
aegis/i18n/locales/zh.py Same i18n updates for Simplified Chinese.
aegis/i18n/locales/zh_hant.py Same i18n updates for Traditional Chinese.

@lbedner lbedner merged commit eb7ced2 into main Jun 7, 2026
9 checks passed
@lbedner lbedner deleted the fix-deploy branch June 7, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants