gml: decode feature-reference elements with an object-type name suffix#537
Merged
Conversation
Some GML application schemas name a feature-reference property element with the referenced feature type appended (e.g. foo_Bar and foo_Baz instead of foo as the relationship role is named in the logical model). The GML decoder matched none of these, so the property was silently skipped. - FeatureTokenDecoderGmlInputProfile: new objectTypeSuffixedProperties, the names/aliases of feature-reference properties whose wire element carries a _<ObjectType> suffix. - FeatureTokenDecoderGml.lookupChild: for a declared property, accept an element whose local name is the base name optionally followed by a _<segment> suffix; the suffix is ignored, since the referenced type is carried by the reference itself. - Spec coverage for the suffix match (declared/undeclared, suffixed/plain).
3 tasks
azahnen
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some GML application schemas name a feature-reference property element with the referenced feature type appended (e.g.
foo_Barandfoo_Bazinstead offooas the relationship role is named in the logical model). The GML decoder matched none of these, so the property was silently skipped.FeatureTokenDecoderGmlInputProfile: newobjectTypeSuffixedProperties, the names/aliases of feature-reference properties whose wire element carries a_<ObjectType>suffix.FeatureTokenDecoderGml.lookupChild: for a declared property, accept an element whose local name is the base name optionally followed by a_<text>suffix; the suffix is ignored, since the referenced type is carried by the reference itself.