merge bytecode / memory / precompile lookups into a shared BusInteraction#228
Merged
Conversation
TomWambsgans
added a commit
that referenced
this pull request
May 21, 2026
Conflicts resolved by adopting main's BusInteraction refactor (PR #228) while keeping Goldilocks-specific bits: - Ported poseidon_8/mod.rs to the new bus_interactions() API (renamed COL_FLAG→COL_MULTIPLICITY, COL_PRECOMPILE_DATA→COL_DOMAINSEP, POSEIDON_PRECOMPILE_DATA(=1)→POSEIDON_DOMAINSEP_BASE(=3); merged lookups() + bus() into bus_interactions()). - table_enum: kept Table::poseidon8(), adopted MAX_BUS_WIDTH/LOG_MAX_BUS_WIDTH. - extension_op air.rs: virtual cols at indices 21,22 (DIMENSION=3) with new names COL_MULTIPLICITY/COL_DOMAINSEP_EXTENSION_OP; switched to eval_bus_virtual. - verify_execution: kept *get_poseidon8(), added MAX_BYTECODE_LOG_SIZE check. - Renamed poseidon_16 references → poseidon_8 in test (prove_poseidon_8.rs). - Removed the spurious poseidon_16/ directory left in the tree. - Adjusted recursion.py to use copy_ef instead of copy_5 (DIM=3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More harmonious logup interractions. Bonus: saves almost 1K cycles / recursion