refactor(poseidon1): build circulant MDS via np.roll#738
Open
tcoratger wants to merge 1 commit into
Open
Conversation
Replace the nested Python loop in _build_circulant_mds with a single numpy comprehension. Row i of a circulant matrix is the first row rolled right by i positions, so the matrix is built as a stack of rolled rows reduced mod p. Verified element-wise equivalent against the width-16 and width-24 spec rows and a value crossing the modulus. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_build_circulant_mdswith a single numpy comprehension: rowiof a circulant matrix is just the first row rolled right byipositions.Test plan
uv run pytest tests/ -k poseidon1— 8 tests pass.🤖 Generated with Claude Code