refactor(lstar): use math.ceil for 2/3 supermajority threshold#742
Open
tcoratger wants to merge 1 commit into
Open
refactor(lstar): use math.ceil for 2/3 supermajority threshold#742tcoratger wants to merge 1 commit into
tcoratger wants to merge 1 commit into
Conversation
Replace the -(-n * 2 // 3) ceiling-division trick with math.ceil. The trick relied on the reader recognising that flooring on a negated value yields a ceiling; math.ceil expresses the intent directly. Validator counts are capped well within float precision, and the int() cast keeps the multiplication out of the Uint64 operator that rejects plain-int operands. Equivalence verified across n = 0, 1, 2, 3, 99..101, 4096, 8192, 99999. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-(-num_validators * 2 // 3)ceiling-division trick withmath.ceil(int(num_validators) * 2 / 3).math.ceilexpresses the intent directly.int()cast keeps the multiplication out of theUint64.__mul__overload that rejects plain-int operands, and validator counts are capped well within float precision.Test plan
ruff check src/lean_spec/forks/lstar/spec.py— clean.n ∈ {0, 1, 2, 3, 99, 100, 101, 4096, 8192, 99999}.🤖 Generated with Claude Code