fix: sync lean-toolchain for test projects that build against Verso - #967
fix: sync lean-toolchain for test projects that build against Verso#967kim-em wants to merge 1 commit into
Conversation
`update-subverso.sh` iterated over `lake-manifest.json` files, so it never reached `literate-config` and `literate-multi-root`, which require Verso by path and therefore have no manifest. Their toolchains were left behind on every bump, failing the consistency check. List those projects in `test-projects/root-toolchain-projects.txt` and read it from the updater, the check, and the `!consistent` fixer, so the three cannot drift apart. The fixer resolves the list before checking out the pull request, since it runs with write access and must not take instructions from PR content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0188amTRAvgJg9gKTzsC6KWF
|
:bot: says: Handing this over rather than merging it during the release. @david-christiansen, your call entirely. Background: the v4.34.0-rc2 toolchain bump (#966) failed the SubVerso consistency check because Two things worth your eye rather than a rubber stamp:
Verified by reproducing the actual rc2 failure and watching the updater repair it, with the four test projects deliberately pinned to v4.31.0 left untouched, and by checking the empty-list, missing-list and path-traversal cases all fail loudly rather than passing vacuously. |
This PR keeps
test-projects/literate-configandtest-projects/literate-multi-rooton the root toolchain when it is bumped, so the SubVerso consistency check no longer fails on every toolchain bump.update-subverso.shiterated overlake-manifest.jsonfiles, so it never reached those two projects: they require Verso by path and therefore have no manifest. The projects that must track the root toolchain are now listed intest-projects/root-toolchain-projects.txt, read by the updater, the consistency check, and the!consistentfixer alike, so the three cannot drift apart. Every other test project depends on SubVerso from Git and stays pinned to its own toolchain.The fixer resolves the list before checking out the pull request, since it runs with write access and should not take instructions from pull request content.
No-Changelog: release tooling, with no effect on Verso's users.
🤖 Prepared with Claude Code