Remove resume functionality#671
Draft
rtibbles wants to merge 1 commit into
Draft
Conversation
RestoreManager pickled itself - including the channel tree - at every chef step, which crashed runs when the tree contained unpicklable objects such as threading.local (which the file pipeline now embeds). The resume feature it supported is not actively used, so remove it entirely: delete RestoreManager and the Status enum, drop the --resume and --step CLI arguments, and rewrite uploadchannel as a plain linear flow using local variables instead of pickle-backed step gating. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rtibbles
force-pushed
the
progress_pickling
branch
from
641a8dd to
27ab601
Compare
rtibbles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RestoreManagerpickled itself — including the channel tree — at every chef step, which crashed runs when the tree contained unpicklable objects such asthreading.local(which the file pipeline now embeds). The resume feature this supported is not actively used, so remove it entirely rather than chase picklability:managers/progress.py(RestoreManagerand theStatusenum)--resumeand--stepCLI argumentsuploadchannelas a plain linear flow using local variables instead of pickle-backed step gatingconfig.py(PROGRESS_MANAGER,RESTORE_DIRECTORY,FILE_STORE_LOCATION,get_restore_path,init_file_mapping_store) and the mid-uploadset_uploadingcheckpoint inmanagers/tree.py--resume/--stepand therestore/directoryReferences
Extracted from in-progress spreadsheet chef work; no linked issue.
Reviewer guidance
uv run --group test pytest— full suite passes.tests/test_argparse.pywas updated to drop the resume/step cases.The integration chef (
tests/test_chef_integration.py) was run against production Studio and completed a full upload through the new linear flow.Behavioral notes worth weighing:
--resumeor--stepwill now fail with an argparse error rather than being silently ignored.restore/directory is no longer created or cleaned.AI usage
I used Claude Code to implement the removal and update the tests and docs; I reviewed the final diff.
🤖 Generated with Claude Code