[19.0][MIG] dms_field: Migration to 19.0 + UX modernisation#13
Open
dnplkndll wants to merge 212 commits into
Open
[19.0][MIG] dms_field: Migration to 19.0 + UX modernisation#13dnplkndll wants to merge 212 commits into
dnplkndll wants to merge 212 commits into
Conversation
versions of muk_dms than 12.0.2.0.0. Tested from 1.2.4 version.
In v13, this test is programmed in such a way that the demo user is supposed to be able to copy that subdirectory: https://github.com/OCA/dms/blob/c3f802db43362127e70d8c7b4987fb71d4c1f01c/dms/tests/test_directory.py#L40 However, in OCA#7 that test was modified indicating that demo user didn't have permissions to do that: https://github.com/OCA/dms/blob/e3b6d8d24534f2a68bfb88e310cc70cefe46bb64/dms/tests/test_directory.py#L39 Rolling back that change to ensure premissions remain the same in both versions of the module. Also changing the directory to test to ensure it contains no SVG files, whose detection seems to differ among environments, and which have some specific permission restrictions that can make the modified test fail or pass. @Tecnativa TT25645
dnplkndll
force-pushed
the
19.0-mig-dms_field
branch
from
1a226ca to
6f4d9ea
Compare
- sort-imports: reorder import declarations by member-syntax tier then first-member alphabetically (multiple before single, none first) - no-implicit-coercion: replace unary + on toFixed() results with Number() - no-negated-condition: flip !== null ternary to positive condition - no-inline-comments: remove inline comment on code line - capitalized-comments: capitalize section comments in _ACCENT_MAP
TT46805 [UPD] Update dms_auto_classification.pot
…ssions can use the wizard TT46805
[UPD] Update dms_auto_classification.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: dms-16.0/dms-16.0-dms_auto_classification Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms_auto_classification/
Changes done: - The full path is now shown in the detail line. - The dms file that will be created will be with the name (not the full file path). - When scanning the .zip files the folders are skipped. - Add more use cases in tests - Improve documentation TT49047 [UPD] Update dms_auto_classification.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: dms-16.0/dms-16.0-dms_auto_classification Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms_auto_classification/
…he same label WARNING devel odoo.addons.base.models.ir_model: Two fields (file_id, data_file) of wizard.dms.classification.detail() have the same label: File. [Modules: dms_auto_classification and dms_auto_classification] TT51051 [UPD] Update dms_auto_classification.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: dms-16.0/dms-16.0-dms_auto_classification Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms_auto_classification/
…CL to group_dms_user TT60719
…ies (company compatibility) It is important not to apply sudo() to filter by the directories to which the user has access and to filter only by those of the appropriate company. TT60719
- `groups_id` → `group_ids` on both `ir.actions.act_window` records (19.0 field rename) - Tests: replace `env.ref()` demo-data lookups with inline fixtures in `setUpClass` — OCA CI runs without demo data
access_wizard_dms_classification_detail_user pointed to model_dms_classification_template instead of model_wizard_dms_classification_detail, so group_dms_user never got CRUD access to wizard.dms.classification.detail — causing AccessError when running the classify wizard as a regular DMS user.
dnplkndll
force-pushed
the
19.0-mig-dms_field
branch
from
6f4d9ea to
278216f
Compare
…ation pylint-odoo W8161 mandates self.env._() over the legacy _() lazy import.
dnplkndll
force-pushed
the
19.0-mig-dms_field
branch
from
278216f to
50748de
Compare
…ile_id to break 19.0 recursive invalidation loop
Full source of dms_field at 18.0.1.1.3 — replays authorship from the original [ADD] (Creu Blanca / Carlos Roca) and subsequent contributions (Tecnativa / Víctor Martínez, SimonRubino / PyTech). CONTRIBUTORS.md lists the full attribution chain.
dnplkndll
force-pushed
the
19.0-mig-dms_field
branch
4 times, most recently
from
3ebd721 to
066837a
Compare
- Rewrote setUpClass to create fixtures inline (storage, dms.access.group,
dms.field.template, template root directory) — OCA CI runs without demo
data so env.ref("dms_field.field_template_partner") would fail
… dms_list) - Add hero_chips named slot to dms.field.template form view - Replace custom file-node preview in dms_list renderer with FilePreviewPane from base DMS (download, open-form, share, extra-action registry) - Directory-node panel retained; file branch now leverages shared preview infrastructure
- W8161 (prefer-env-translation): replace bare _() with self.env._() in dms_access_group, dms_directory, dms_field_template, dms_storage, ir_ui_view; drop unused _ from odoo imports - W8301 (translation-not-lazy): dms_field_template._prepare_autogenerated_group — inline % interpolation → self.env._(..., model=, name=, id=) named kwargs - W8163 (no-search-all): dms_field_mixin.models_to_track_dms_field_template — search([]) → search([], limit=False) - ESLint sort-imports: dms_list_renderer.esm.js — move @DMS import before @odoo/owl block (alphabetical module prefix order)
…cuments app-name collision)
dnplkndll
force-pushed
the
19.0-mig-dms_field
branch
from
066837a to
38b4bec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
dms_fieldfrom 18.0 to 19.0.Non-mechanical adaptations worth flagging
setUpClassrewritten to create all fixtures inline (dms.storage,dms.access.group,dms.field.template, template root directory viacreate_dms_directory) —env.ref("dms_field.field_template_partner")relies on demo data absent in OCA CI.dms.field.template.create()only auto-creates it underinstall_mode=True; tests don't run with that context.UX modernisation
dms.field.templateform: addedname="hero_chips"slot to title block for plugin chip injection.dms_listrenderer: file-node preview branch replaced withFilePreviewPanefrom base DMS (download, open-form, share,dms.preview_actionsregistry). Directory-node stats panel retained.