[fork-CI] [19.0][MIG] project_reviewer: Migration to 19.0#3
Draft
dnplkndll wants to merge 39 commits into
Draft
Conversation
Without this patch, upgrading the addon raises this error:
Field 'partner_id' used in context ({'default_partner_id': partner_id, 'default_sale_order_id': active_id}) must be present in view but is missing.
@moduon MT-3426
…d always This reverts OCA#1416 and adds instead a different, more accurate fix for the problem (which kept yielding different errors). The main source of problem is that the same view is adding a `project_id` field and editing another `project_id` fields' attributes. For this reason, installing the module didn't give any problems, but updating it was problematic. The new field appeared above in the view hierarchy than the old one. The xpath for the old one was less specific than necessary, and then found the new one instead. The new one is within a tree subview, so the model is different (`sale.order.line` instead of `sale.order`). Thus the fields exposed to that field are different, and failures happened a bit randomly. @moduon MT-3426
This module adds the behavior to change the Personal Stage of the task to the first Folded one when the task reachs an stage with "Mark as Done". If the Personal Stage is already folded, does nothing. Simplifies the behavior of closing a task, go back to Personal Stages and move it to the Pesonal Done stage. Chooses Personal Stages with the same name before Closing stages or Folded stages.
Tests to ensure expected behaviour
…akes original test fail By inheriting the tests of project module one of the test defined in the original module is failing, by copying the setUpClass we avoid this error.
Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_personal_stage_auto_fold Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_personal_stage_auto_fold/hr/
…eld wrapping The two onchange tests pinned the exact wrapper tag of the appended template text. Odoo core flips that wrapper between releases (<span> <-> <p>), so the hard-coded assertions break on every change. Compare against the template's own stored Html value instead, so both sides track whatever core produces.
Currently translated at 100.0% (3 of 3 strings) Translation: project-16.0/project-16.0-project_reviewer Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_reviewer/it/
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
project_reviewerfrom 18.0 to 19.0.Fork-CI validation PR. Will be closed once upstream PR against OCA/project is
opened from the same branch.