[fork-CI] [19.0][MIG] report_display_name_in_footer: Migration to 19.0#4
Draft
dnplkndll wants to merge 7 commits into
Draft
[fork-CI] [19.0][MIG] report_display_name_in_footer: Migration to 19.0#4dnplkndll wants to merge 7 commits into
dnplkndll wants to merge 7 commits into
Conversation
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
- Drop views/report_templates.xml entirely: 19.0 core absorbed the footer-name hook into all seven web.external_layout_* templates (t-if="report_type=='pdf' and display_name_in_footer"). The module now provides only the generic, any-model config-driven activation (report.display_name_in_footer_models) via _pre_render_qweb_pdf — distinct from core account, which sets the flag for invoices only. Signed-off-by: Don Kendall <dkendall@ledoweb.com>
dnplkndll
force-pushed
the
19.0-mig-report_display_name_in_footer
branch
from
6bd9f13 to
8aef7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
report_display_name_in_footerfrom18.0to19.0. Follows the OCA migration guide.19.0 relevance
19.0 core absorbed the footer-name template hook into all seven
web.external_layout_*templates (each renderst-if="report_type == 'pdf' and display_name_in_footer"), andaccountsets that flag for invoice reports only. This module remains distinct: it provides the generic, any-model activation via thereport.display_name_in_footer_modelsconfig parameter (per-model list orall), driven from_pre_render_qweb_pdf— the samedata.update({"display_name_in_footer": True})mechanism coreaccountuses.Non-mechanical adaptations worth flagging
views/report_templates.xmlremoved entirely. The 18.0 module re-implemented the footer-name markup via xpath inheritance of the layout templates; 19.0 core now ships those hooks natively, so the inheritance is redundant (and its xpaths no longer match the restructured templates). The module is now model-only.