Various fixes and improvements across the whole project#38
Open
leducp wants to merge 1 commit into
Open
Conversation
Data loss & crashes: - serialize: parse labels before links so label-routed wires survive save/load - engine: fail build with MissingInput/DuplicateInputWiring instead of throwing at tick - app: wrap engine play()/tick() so a compute exception stops the engine, not the editor - migrate: refuse to overwrite input, reject already-migrated and empty-result files Core robustness: - contain malformed JSON fields as per-item diagnostics instead of leaking json::type_error - reject id 0 / negative ids; guard reserve_ids_above overflow - throw on non-array "pipelines"; validate/clamp theme grid spacing and font size - fix AddStage/AddModeProfile undo deleting pre-existing entries - repair_label_clusters honors first-by-id; registry heterogeneous lookup; add Lint kind Memory safety (Python bindings): - find_node/find_link/find_attr return copies; engine handles are shared_ptr surviving build() - Step accessors throw instead of segfaulting; Stage keeps name alive; complete Diagnostic.Kind - guard external-IO downcast (FactoryTypeMismatch); delete Engine copy/move; probe sink steps Performance: - cache node geometry per frame (kills O(pins^2) CalcTextSize); cull off-screen links - debounce live-engine rebuild; pre-resolve per-stage blocks; drop per-frame exception throws Build/packaging/docs/CI: - fix README quick start; declare conan dep; fatal setup failure - install rules + cmake.install packaging + version; gate IPO out of package builds - BUILD_TESTS without BUILD_APP; pin GLFW commit; MIT license notices - add GitHub Actions CI running the full suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data loss & crashes:
Core robustness:
Memory safety (Python bindings):
Performance:
Build/packaging/docs/CI: