test: retry recursive teardown removals — kill a class of phantom failures#549
Open
leeovery wants to merge 1 commit into
Open
test: retry recursive teardown removals — kill a class of phantom failures#549leeovery wants to merge 1 commit into
leeovery wants to merge 1 commit into
Conversation
…lures A full-gate run went red on ENOTEMPTY inside an afterEach rmSync, in a suite unrelated to what was being changed, while four background agents churned temp directories. It passed 3/3 in isolation: the engine spawns git subprocesses, git drops lock and temp files a moment after the command returns, and a recursive remove that has just emptied a directory then fails to remove it. Every recursive teardown removal in tests/scripts now passes maxRetries/retryDelay, as the prose-test world builder already did. 64 call sites across 25 suites; no behavioural change, and a false red on the gate costs more than the churn. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOTEMPTYinside anafterEachrmSync, in a suite unrelated to the change being made, while four background agents were churning temp directories. The same suite passed 3/3 in isolation.tests/scriptsnow passesmaxRetries: 5, retryDelay: 100, which is what the prose-test world builder already used for exactly this reason. 64 call sites across 25 suites, mechanical, no behavioural change.Test plan
npm testgreen: 1699 tests, 0 fail.🤖 Generated with Claude Code