fix(implementation): environment setup belongs to the setup reference alone#553
Open
leeovery wants to merge 1 commit into
Open
fix(implementation): environment setup belongs to the setup reference alone#553leeovery wants to merge 1 commit into
leeovery wants to merge 1 commit into
Conversation
leeovery
force-pushed
the
fix/environment-check-gathers-only
branch
2 times, most recently
from
July 26, 2026 13:37
42108f0 to
4c916fa
Compare
… alone The entry skill asked for setup instructions and wrote the document the processing skill also writes, while its own header said "information gathering only. Do NOT execute any setup commands at this stage. The processing skill contains instructions for handling environment setup." Whichever ran first won and the other silently took its already-exists arm. A prose-test walker hit exactly that. An earlier attempt at this split ownership — entry asks, process records — which only moved the confusion. Lee's call, and the right one: one file owns it. environment-setup.md checks whether the document exists, asks when it does not, and stores the answer; by implementation time it exists and is ready to use, and if it somehow does not, the same reference creates it. No special handling, no second owner. So the entry sheds it entirely: Step 4 (Check Environment) and environment-check.md are gone, and the handoff drops its `Environment:` line, which existed only to carry an answer the entry no longer gathers. environment-setup.md returns to exactly what it was. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
leeovery
force-pushed
the
fix/environment-check-gathers-only
branch
from
July 26, 2026 13:43
4c916fa to
1976e37
Compare
leeovery
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The entry skill asked for setup instructions and wrote the document the processing skill also writes — while its own header said "information gathering only. Do NOT execute any setup commands at this stage. The processing skill contains instructions for handling environment setup." Whichever ran first won and the other silently took its already-exists arm. A prose-test walker hit exactly that on both runs.
One file owns it now.
workflow-implementation-process/references/environment-setup.mdchecks whether the document exists, asks when it does not, and stores the answer. By implementation time it exists and is ready to use; if it somehow does not, the same reference creates it. No special handling, no second owner.So the entry sheds it entirely:
Step 4: Check Environmentremoved (Invoke becomes Step 4)references/environment-check.mddeletedEnvironment:line, which existed only to carry an answer the entry no longer gathersenvironment-setup.mdreturns to exactly what it was onmainAn earlier version of this PR split ownership — entry asks, process records — which only relocated the confusion. This replaces it.
The
implementation-picks-first-taskprose case is updated to the settled design: the entry hands off without touching the environment, and the setup step consumes the answer and records the document.Test plan
npm testgreen: 1699 tests, 0 fail. Corpus valid, 13 cases.environment-setup.mdis byte-identical tomain— verified.🤖 Generated with Claude Code