fix(discussion-entry): the handoff reports the source it actually had#558
Open
leeovery wants to merge 1 commit into
Open
fix(discussion-entry): the handoff reports the source it actually had#558leeovery wants to merge 1 commit into
leeovery wants to merge 1 commit into
Conversation
One arm serves both `fresh` and `topic-provided` and hardcoded `Source: fresh`, so a discussion arriving with a topic already chosen — from the map, or a continue menu — told the processing skill it was a direct entry. Found by a prose-test walker, which recorded it as a DEVIATION on a case that otherwise passed: a marker is a finding in its own right. Scope checked before changing anything: the sibling entry skills carry a `Source:` line only in single-source arms, where the fixed wording is accurate. This was the one multi-source arm stating a constant. Impact is narrower than it first looks — nothing in workflow-discussion-process reads `Source:`, so this is context handed downstream being wrong rather than a branch being taken wrongly. Worth correcting; not worth overstating. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/workflow-discussion-entry/references/invoke-skill.mdline 68 opens#### If source is \fresh` or `topic-provided`— and line 75 then statesSource: fresh`. A discussion arriving with a topic already chosen (from the epic map, or a continue menu) told the processing skill it was a direct entry.Source: {source}, the variable the entry skill already set.DEVIATIONon a case that otherwise passed 5/5 — a marker is a finding in its own right, which is why they're reported even on green cases.Scope checked before changing anything: the sibling entry skills (
research,investigation) carry aSource:line only inside single-source arms, where the fixed wording is accurate. This was the one multi-source arm stating a constant.Impact, honestly: nothing in
workflow-discussion-processreadsSource:— grep finds no consumer. So this is context handed downstream being wrong, not a branch being taken wrongly. Worth correcting; not worth overstating.Test plan
npm testgreen: 1699 tests, 0 fail.discussion-entry-seeds-from-carrierpassed 5/5 with this DEVIATION recorded; re-running it should now produce the same pass with no marker.🤖 Generated with Claude Code