Skip to content

fix(physics): restore 2D gravity compatibility - #13

Merged
amasiye merged 2 commits into
mainfrom
develop
Aug 7, 2026
Merged

fix(physics): restore 2D gravity compatibility#13
amasiye merged 2 commits into
mainfrom
develop

Conversation

@amasiye

@amasiye amasiye commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore the PHP-facing 2D gravity contract to positive-Y-down (0, 980, 0)
  • document the focused 0.9.1 compatibility release
  • preserve explicit project gravity overrides

Verification

  • 196 PHPUnit tests, 991 assertions
  • composer validate --strict
  • changed PHP files pass syntax checks

@amasiye
amasiye merged commit 0761f79 into main Aug 7, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99d6fc486b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{
$GLOBALS['lenga_physics_gravity_test_state'] = [
'gravity2D' => ['x' => 0.0, 'y' => -9.8],
'gravity2D' => ['x' => 0.0, 'y' => 980.0],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Implement the gravity fix before releasing 0.9.1

This changes only a test fixture, not shipped package behavior, and even the fixture value is overwritten by Physics2D::setGravity() before the test reads it. Since Physics2D::getGravity() still returns the native bridge value and no src/ file changes in this commit, installing 0.9.1 cannot restore the advertised (0, 980) default for users relying on default 2D gravity; the actual runtime/source behavior needs to be changed and the untouched default asserted before publishing the release note.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant