Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99d6fc486b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| $GLOBALS['lenga_physics_gravity_test_state'] = [ | ||
| 'gravity2D' => ['x' => 0.0, 'y' => -9.8], | ||
| 'gravity2D' => ['x' => 0.0, 'y' => 980.0], |
There was a problem hiding this comment.
Implement the gravity fix before releasing 0.9.1
This changes only a test fixture, not shipped package behavior, and even the fixture value is overwritten by Physics2D::setGravity() before the test reads it. Since Physics2D::getGravity() still returns the native bridge value and no src/ file changes in this commit, installing 0.9.1 cannot restore the advertised (0, 980) default for users relying on default 2D gravity; the actual runtime/source behavior needs to be changed and the untouched default asserted before publishing the release note.
Useful? React with 👍 / 👎.
Summary
(0, 980, 0)Verification
composer validate --strict