fix: add JSON omitempty and omitzero tags to asyncapiv3 types#286
Merged
Conversation
Owner
|
Sorry about the delay, I had some changes in my life this 2 past months, I'll take a look ASAP. |
|
Fixes also #300 |
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
…tive The omitempty/omitzero tags added for asyncapiv3 use the `omitzero` option, which requires Go 1.24+. Without bumping the toolchain it is silently ignored, so the binding structs, OAuthFlows, Components and Operation.Messages would still serialize as zero values. - go.mod: go 1.21 -> 1.24, toolchain go1.21.4 -> go1.24.0 (raises the library's minimum Go version to 1.24) - Dagger CI images (the actual build/lint compilers): golang 1.21.4-alpine -> 1.24-alpine, golangci-lint v1.62.0 -> v1.64.8 (last v1, keeps the v1 .golangci.yml format and bundles Go 1.24) - make the Dagger CI module self-contained: it imported the library only for two self-signed-certificate test helpers, which forced the Dagger engine to load the library's go 1.24 module with its older bundled Go and fail to bootstrap. Copy those helpers into the CI module and drop the parent dependency so the engine only loads the CI module itself. - drop exportloopref (inactivated since Go 1.22 loopvar) and an unused funlen nolint directive surfaced by the newer linter; rewrap a few over-length doc comments. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lerenn
force-pushed
the
add-json-omitempty
branch
from
704df0d to
4e189da
Compare
lerenn
added a commit
that referenced
this pull request
Jun 11, 2026
Recognizes @justenstall for #286 (JSON omitempty/omitzero tags for the asyncapiv3 types). Co-authored-by: Louis FRADIN <louis.fradin@pm.me> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
omitemptyandomitzeroto the JSON struct tags for any fields that are not required according to the AsyncAPI specification. Some fields required the neweromitzerotag to be excluded without changing them to a pointer type, but I usedomitemptyfor every other field for maximum backwards compatibility.There is also a bug fix for the
Operation.Descriptionfield, which was set to usestringas its name in JSON.I documented that the
MessageTrait.Payloadfield should probably be removed, but kept it for now.I also documented some nuances with the interpretation of the
Operation.Messagesfield.