Add kafka writer options#293
Merged
Merged
Conversation
Owner
|
Sorry about the delay, I had some changes in my life this 2 past months, I'll take a look ASAP. |
Contributor
Author
|
Any chances this gets merged in the next time? |
Add a WithWriterOptions controller option and a set of WriterOption helpers (batch size/bytes/timeout, backoff, attempts, read/write timeout, async) so the kafka.Writer used on Publish can be tuned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lerenn
force-pushed
the
kafka-writer-options
branch
from
41285da to
c50f626
Compare
Contributor
Author
|
Thx 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to adjust the kafka writer options for testing.
With the default settings the kafka writer sends single messages only every second (due to the default batch size of 100) which slowed down our tests.
This PR allows to adjust the options of the kafka writer.