Skip to content

Fix AdaBelief variance updates #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linrock wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix AdaBelief variance updates #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ranger21/ranger21.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,13 +735,16 @@ def step(self, closure=None):
if self.use_adabelief:
grad_ma.mul_(beta1).add_(grad, alpha=1 - beta1)
grad_residual = grad - grad_ma
variance_ma_belief.mul_(beta2).addcmul(
variance_ma_belief.mul_(beta2).addcmul_(
grad_residual, grad_residual, value=1 - beta2
)
# print(f"upper loop grad = {grad.shape}")
variance_ma.mul_(beta2).addcmul_(grad, grad, value=1 - beta2)
# print(f"variance_ma, grad adjusted")
variance_ma_debiased = variance_ma / bias_correction2
if self.use_adabelief:
variance_ma_debiased = variance_ma_belief / bias_correction2
else:
variance_ma_debiased = variance_ma / bias_correction2

variance_ma_sum += variance_ma_debiased.sum()
# print(f"variance_ma_sum = {variance_ma_sum}")
Expand Down Expand Up @@ -909,7 +912,8 @@ def step(self, closure=None):
# Maintains the maximum of all 2nd moment running avg. till now
torch.max(max_variance_ma, variance_ma, out=variance_ma)
# Use the max. for normalizing running avg. of gradient
denom = (variance_ma.sqrt() / math.sqrt(bias_correction2)).add_(
variance_source = variance_ma_belief if self.use_adabelief else variance_ma
denom = (variance_source.sqrt() / math.sqrt(bias_correction2)).add_(
group["eps"]
)

Expand Down