Replace CA-enforcement for MaxNames with Custom Lint#8739
Open
Replace CA-enforcement for MaxNames with Custom Lint#8739
Conversation
aarongable
previously approved these changes
Apr 28, 2026
aarongable
dismissed
their stale review
Oops, didn't mean to hit Approve yet; I know the rest of this PR is still coming.
…maxnames-with-lint
Addresses reviewer feedback.
Includes removal of configuration from test configs.
…maxnames-with-lint
…maxnames-with-lint
Necessarily removes maxNames from csr.VerifyCSR signature. Also removes maxNames-related items from CSR and CA tests.
aarongable
reviewed
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Two nits on the PR description:
- You're going to need to file an internal jira ticket asking SRE to remove the maxNames item from the CA's config, then reference that ticket with a line like
IN-WXYZ tracks the corresponding production changes. - We link from the PR to the issue it's addressing by having the last line of the PR description be
Fixes https://github.com/letsencrypt/boulder/issues/8391.
| // limits are per section 7.1 of our combined CP/CPS, under "DV-SSL | ||
| // Subscriber Certificate". The value must match the RA and WFE | ||
| // configurations. | ||
| MaxNames int `validate:"required,min=1,max=100"` |
Contributor
There was a problem hiding this comment.
We can't immediately delete this, because it's currently configured in prod. Deploying this change as-is would break, as the CA would refuse to load a config with an unrecognized key.
Instead, update the comment to mark the field as deprecated, and update the config validation from "required" to "omitempty".
| ] | ||
| }, | ||
| "serialPrefixHex": "6e", | ||
| "maxNames": 100, |
Contributor
There was a problem hiding this comment.
Don't remove this from test/config/ yet, since it's still configured in prod. We'll save that for a follow-up PR, after this initial change has been deployed and the prod configs have been updated.
CSR identifiers check needs to have an empty line after the error return. Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely removes maxNames enforcement from CA and CA tests, and replaces with a custom zlint.
Both the RA and the CA use
csr.VerifyCSRto verify various CSR aspects. Validation of maxnames was removed from this function, but separately preserved in the VA at finalize time.maxNames values and on-disk testdata have also been deleted from both csr_tests and ca_tests.
Fixes #8391