Repository navigation
Remove skills migrated to typescript-skill (#227) - #240
Conversation
Remove biome-typescript, fast-check, lemmascript and zod4-typescript from this repository now that leynos/typescript-skill maintains them. Remove the Biome-only tests and fixture support, and point users to the new repository for installation and updates.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Summary
ValidationThe PR objectives report that all listed gates passed for commit Review findingsSeverity counts are unavailable. No current review findings were supplied. WalkthroughThe users’ guide now directs users to ChangesTypeScript skill ownership
Suggested labels: Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Testing (Overall) |  |
Fail the testing check because the pull request changes fresh-install behaviour but adds no test for that change. The diff deletes the four skill trees and their Biome-specific tests. install-skills… |
Add a substantive installer/catalogue test. Run the installer against a controlled managed-checkout fixture and assert that biome-typescript, fast-check, lemmascript, and zod4-typescript are not installed for either agent, while ret… |
| Testing (Unit And Behavioural) | |
The change alters the externally observable install-skills workflow: deleting four directories means the installer no longer copies those skills. The pull request adds no replacement test. Existing … |
Add a behavioural end-to-end test that runs the real install-skills script with the existing temporary HOME and fake Git boundary. Build the managed checkout fixture from the current skills tree, then assert that all four migrated skill… |
| User-Facing Documentation |  |
The users’ guide clearly documents that biome-typescript, fast-check, lemmascript and zod4-typescript moved to leynos/typescript-skill, and that install-skills no longer supplies them. How… |
Add a section to docs/v0-3-0-migration-guide.md that lists the four removed skills, links to leynos/typescript-skill, gives the required installation and update action, and explains any cleanup required for existing locally installed co… |
| Developer Documentation | |
The pull request changes the skill ownership boundary: it deletes the four local skill catalogues, while the user guide states that leynos/typescript-skill is now canonical and that install-skills… |
Update docs/developers-guide.md with the TypeScript skill ownership boundary. State that biome-typescript, fast-check, lemmascript, and zod4-typescript are maintained in leynos/typescript-skill, and state that the current `insta… |
-
Check name Status Explanation Title check The title clearly identifies the removal of migrated skills and includes issue reference #227, which the pull request description references.Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Module-Level Documentation Pass. The pull request adds no module. The only retained Python module it changes, tests/conftest.py, has a module docstring that explains its purpose, pytest fixture utility, and relationship to th…Testing (Property / Proof) The pull request introduces no new invariant, state transition, ordering requirement, or proof assumption. Its non-deletion changes add only a migration notice, remove obsolete developer documentation… Testing (Compile-Time / Ui) The pull request changes only Markdown documentation and Python test support, with no Rust or TypeScript source changes and no compile-time behaviour. It removes obsolete skill documentation and Biome… Unit Architecture PASS — The reviewed diff contains documentation updates, removal of four skill directories, removal of Biome-only test support, and removal of the obsolete fixture export. It adds no query or command … Domain Architecture PASS — The pull request changes documentation, skill catalogue content, and test support only. The authoritative diff shows deletions of the four skill directories and Biome-only tests, plus a migrati… Observability Mark this check PASS. The pull request removes four skill catalogues, obsolete documentation, and Biome-only tests. It does not change service, bootstrap, installer, queue, storage, or network impleme… Description check The pull request description is related to the changeset. It states that the four duplicate skills (biome-typescript, fast-check, lemmascript, zod4-typescript) are removed because they now live in ley… Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Full details: Module-Level Documentation
-
Explanation
Pass. The pull request adds no module. The only retained Python module it changes,
tests/conftest.py, has a module docstring that explains its purpose, pytest fixture utility, and relationship to the plugin and sibling support modules. The other Python files in the diff are deleted.
Full details: Testing (Property / Proof)
-
Explanation
The pull request introduces no new invariant, state transition, ordering requirement, or proof assumption. Its non-deletion changes add only a migration notice, remove obsolete developer documentation, and unregister a deleted fixture. The property-based tests and related Biome test support are deleted with the migrated skill documentation; this does not create a new property-testing obligation.
Full details: Testing (Compile-Time / Ui)
-
Explanation
The pull request changes only Markdown documentation and Python test support, with no Rust or TypeScript source changes and no compile-time behaviour. It removes obsolete skill documentation and Biome-specific tests, updates the fixture export, and adds a migration notice. It introduces no text-based, structured, or UI-adjacent runtime output that requires snapshot coverage; snapshot tests are not appropriate for this documentation-only change.
Full details: Unit Architecture
-
Explanation
PASS — The reviewed diff contains documentation updates, removal of four skill directories, removal of Biome-only test support, and removal of the obsolete fixture export. It adds no query or command implementation, dependency access, persistence, network call, clock use, global state, or side-effect path. The installer and its remaining tests are unchanged. The deleted tests covered the removed Biome documentation and pipeline, so their removal does not introduce a new unit-architecture defect.
Full details: Domain Architecture
-
Explanation
PASS — The pull request changes documentation, skill catalogue content, and test support only. The authoritative diff shows deletions of the four skill directories and Biome-only tests, plus a migration notice and removal of the obsolete fixture export. It introduces no domain model, command, repository, adapter, transport, persistence, or infrastructure logic, so it does not introduce a domain-boundary violation.
Full details: Observability
-
Explanation
Mark this check PASS. The pull request removes four skill catalogues, obsolete documentation, and Biome-only tests. It does not change service, bootstrap, installer, queue, storage, or network implementation code. The unchanged
install-skillsscript still reports repository and destination actions, and the users' guide documents the expected removal and canonical repository. No new production failure mode or process boundary requires logs, metrics, tracing, or alerts.
Full details: Description check
-
Explanation
The pull request description is related to the changeset. It states that the four duplicate skills (biome-typescript, fast-check, lemmascript, zod4-typescript) are removed because they now live in leynos/typescript-skill. It also lists the removed skill directories, references, Biome-only tests and shared test support, plus the migration guide and users' guide updates. It gives validation results and notes that installer integration (
#227) is still outstanding. The description is specific and on-topic, so the check passes.
-
Full details: Testing (Overall)
-
Explanation
Fail the testing check because the pull request changes fresh-install behaviour but adds no test for that change. The diff deletes the four skill trees and their Biome-specific tests.
install-skillscopies every immediate directory under the managed checkout'sskillsdirectory, so the deletions remove four installed skills. The remaining installer tests only assert delivery ofnextestandvidai-mock; the manifest tests enumerate whatever exists and would also pass if a removed skill returned. No test asserts that the four migrated skills are absent from the shipped or installed catalogue.Resolution
Add a substantive installer/catalogue test. Run the installer against a controlled managed-checkout fixture and assert that
biome-typescript,fast-check,lemmascript, andzod4-typescriptare not installed for either agent, while retained skills are still installed. Keep the existing positive installer tests.
Full details: Testing (Unit And Behavioural)
-
Explanation
The change alters the externally observable
install-skillsworkflow: deleting four directories means the installer no longer copies those skills. The pull request adds no replacement test. Existing installer tests execute the real script, but their fixtures contain onlynextestandvidai-mock, so they cannot detect accidental installation ofbiome-typescript,fast-check,lemmascriptorzod4-typescript. The deleted tests covered Biome documentation and pipeline behaviour, not this removal contract.Resolution
Add a behavioural end-to-end test that runs the real
install-skillsscript with the existing temporary HOME and fake Git boundary. Build the managed checkout fixture from the currentskillstree, then assert that all four migrated skill directories are absent from both Codex and Claude destinations. Keep the existing success and error-path assertions.
Full details: User-Facing Documentation
-
Explanation
The users’ guide clearly documents that
biome-typescript,fast-check,lemmascriptandzod4-typescriptmoved toleynos/typescript-skill, and thatinstall-skillsno longer supplies them. However, this is a breaking change because users must change their installation source. The repository’s currentdocs/v0-3-0-migration-guide.mdis the n+1 unreleased migration document, but the pull request does not update it.Resolution
Add a section to
docs/v0-3-0-migration-guide.mdthat lists the four removed skills, links toleynos/typescript-skill, gives the required installation and update action, and explains any cleanup required for existing locally installed copies.
Full details: Developer Documentation
-
Explanation
The pull request changes the skill ownership boundary: it deletes the four local skill catalogues, while the user guide states that
leynos/typescript-skillis now canonical and thatinstall-skillsno longer supplies them. The developer guide'sinstall-skillssection (lines 269–285) documents only the helper and Rust sources and does not record this boundary or the current installer limitation. The installer is unchanged and still fetches onlyagent-helper-scriptsandrust-skill. The pull request therefore leaves a changed maintainer-facing architecture undocumented indocs/developers-guide.md. No completed roadmap item or new execplan is present.Resolution
Update
docs/developers-guide.mdwith the TypeScript skill ownership boundary. State thatbiome-typescript,fast-check,lemmascript, andzod4-typescriptare maintained inleynos/typescript-skill, and state that the currentinstall-skillsscript does not fetch that repository. Record the repository-boundary decision in the relevant design document or ADR if this separation is intended as a lasting architecture change.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Gather four guides; let them roam,
Point each reader to its home.
Fold the pipeline notes away,
Set the fixture down today.
Let old tests rest in the stack,
Send the skill guides on their track.
Comment @coderabbitai help to get the list of available commands.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR de-duplicates four skills by removing their local catalogue entries and Biome-specific validation infrastructure, adds migration guidance to the users’ guide, and leaves installer integration for the external TypeScript catalogue as a follow-up. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@coderabbitai approve |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
✅ Action performedComments resolved and changes approved. |
List the four removed skills and provide installation and update commands for the canonical catalogue. Explain how to preserve local customizations and replace stale installed copies in both agents.
Summary
This branch removes the duplicate
biome-typescript,fast-check,lemmascriptandzod4-typescriptskills now maintained in leynos/typescript-skill, preventing the two catalogues from diverging.Partially addresses #227: the four skill directories, their references, and the Biome-only tests and shared test support are removed. The migration guide documents installation, updates, and cleanup of existing local copies. Installer integration remains outstanding, so this pull request does not close the issue.
Review walkthrough
Validation
All gates passed sequentially for the published candidate
b47418c:Notes
The installer does not yet fetch the TypeScript catalogue. Completing #227 requires that integration and validation that a fresh installation supplies the TypeScript router and migrated skills from their new home.