Refspace fixes - #4538
Open
roystgnr wants to merge 7 commits into
Open
Conversation
I don't think this is a slow one but it's worth logging.
I'm not sure how we had the wrong data here.
Rochi found bugs in our higher-order Pyramids reference elements, and these tests catch them.
Member
Author
|
I think we may have a threading race condition problem with |
jwpeterson
approved these changes
Sep 2, 2026
Comment on lines
+47
to
+55
| {-0.5, -0.5, 0.5}, | ||
| {0.5, -0.5, 0.5}, | ||
| {0.5, 0.5, 0.5}, | ||
| {-0.5, 0.5, 0.5}, | ||
| {0, 0, 0}, | ||
| {0, -Real(2)/3, Real(1)/3}, | ||
| { Real(2)/3, 0, Real(1)/3}, | ||
| {0, Real(2)/3, Real(1)/3}, | ||
| {-Real(2)/3, 0, Real(1)/3} |
Member
There was a problem hiding this comment.
Hmm... I don't think I realized that the base class's _master_points array was meant to have entries for all possible subtypes that might exist? Maybe we should document that better somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of @rochi00's branches his new test coverage discovered some utterly broken master point coordinate definitions for Pyramid13, Pyramid14, and especially Pyramid18. I fixed those, added some tests for the fix, and it turns out Tri7/Prism20/Prism21 also had issues. All fixed and in test coverage now.