fix(varint): reject 10-byte terminator overflow and align error types - #1462
Merged
Conversation
Harden decode_uvarint and decode_uvarint_from_stream against encodings whose terminating byte overflows 64 bits, and raise ParseError consistently for over-long buffer-path failures. Document decode_varint_with_size's truncation contract without changing its behavior. Fixes #1458 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1458
What was wrong?
A 10-byte uvarint encoding whose terminating byte still carries extra payload bits could decode to a value greater than 2^64-1 (e.g.
decode_uvarint(b"\xff" * 9 + b"\x7f")). Over-long buffer-path failures also raisedValueErrorwhile the stream decoder raisedParseError, so callers catching only one type handled the two malformation classes inconsistently.How was it fixed?
_reject_uvarint_overflowguard used bydecode_uvarintanddecode_uvarint_from_streambefore returning a decoded value.ParseErrorwith the same message as the stream decoder.decode_uvarint_from_streamanddecode_varint_with_size(truncation/partial-return contract documented; behavior ofdecode_varint_with_sizeunchanged for WebRTCexcept ValueErrorguards).Test plan
pytest tests/core/utils/test_varint.py tests/core/utils/test_varint_message_limits.pymake lintmake typecheckmake testmake linux-docsCute Animal Picture