You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR template omits two requirements already enforced by CONTRIBUTING.md. Add explicit Checklist reminders for the 100% line-coverage gate and for updating matching provider code, documentation, and integration tests together.
Name the required coverage gate and its test:coverage / coverage:check commands.
Make the provider-triad reminder conditional on changes under src/lib/db/providers/, naming docs/providers/ and tests/integration/db/ in the same PR.
Testing
Verified the checklist against CONTRIBUTING.md and reviewed the diff. Full Linux validation used the repository's unchanged CI workflow on commit ff9874b032879ccb5bfcb333e9d44943e790ed2e: run and logs.
All 391 core test files and 34 component isolation groups passed via bun run test:coverage.
bun run coverage:check: 46,324 / 46,324 lines (100%).
Format, lint, typecheck, knip, README/chart/channel/security drift guards, application build, library build, and package type-resolution checks passed.
The CI run's overall status is red solely because SonarCloud Analysis cannot authenticate from this fork (SONAR_TOKEN / project access unavailable). Every test/build job listed above passed. CONTRIBUTING.md and CLAUDE.md identify CI as the merge gate, and CLAUDE.md explicitly excludes SonarCloud from required checks; the upstream workflow also skips SonarCloud for fork PRs. Upstream required workflows still need their normal maintainer approval.
Full validation ran on GitHub-hosted Linux because this Windows host's Docker Desktop fails at inference-manager initialization and its native component runner encounters SQLite cleanup EBUSY. No full native-Windows pass is claimed.
Checklist
Both issue acceptance criteria are present under Checklist.
The wording matches the contribution guide.
Full tests and the 100% line-coverage gate passed on the submitted commit.
Diff reviewed; provider triad does not apply to this template-only change.
Additional Notes
AI-assisted implementation, review, and validation. This branch starts independently from main and contains only the PR-template change.
CI follow-up
The fork-run SonarCloud 401 is tracked in #732 and fixed by #733. The inherited condition admitted fork-owned pushes and fork-local PRs to the canonical SonarCloud project. The dedicated CI fix run now succeeds: all nine executable test/build jobs pass, and SonarCloud is scoped to the canonical repository. That run tests CI fix commit 80a318b; this PR's exact-head verification remains the original run linked above, whose nine executable jobs passed. Upstream Actions still await maintainer approval.
Checked against #683. Both lines are there and both are accurate: the coverage gate is exactly what scripts/check-coverage.mjs enforces in the required test job, and the triad wording matches the rule as CLAUDE.md states it. That precision is the part that matters in a template, since every future contributor reads it. No test guards this file, and the only other change is one trailing blank line, so the diff stays where it should.
One wording note, not blocking. The coverage item reads "The required CI test job passes...", so its subject is CI, while the point of the issue is for a contributor to catch this before opening the PR, and the other seven items are all written from their side. Something like "I ran bun run test:coverage && bun run coverage:check and line coverage is 100%" would put it in the same voice. The commands you already put in parentheses carry the meaning either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR template omits two requirements already enforced by CONTRIBUTING.md. Add explicit Checklist reminders for the 100% line-coverage gate and for updating matching provider code, documentation, and integration tests together.
Type of Change
Related Issue
Closes #683
Changes Made
test:coverage/coverage:checkcommands.src/lib/db/providers/, namingdocs/providers/andtests/integration/db/in the same PR.Testing
Verified the checklist against CONTRIBUTING.md and reviewed the diff. Full Linux validation used the repository's unchanged CI workflow on commit
ff9874b032879ccb5bfcb333e9d44943e790ed2e: run and logs.bun run test:coverage.bun run coverage:check: 46,324 / 46,324 lines (100%).The CI run's overall status is red solely because SonarCloud Analysis cannot authenticate from this fork (
SONAR_TOKEN/ project access unavailable). Every test/build job listed above passed. CONTRIBUTING.md and CLAUDE.md identify CI as the merge gate, and CLAUDE.md explicitly excludes SonarCloud from required checks; the upstream workflow also skips SonarCloud for fork PRs. Upstream required workflows still need their normal maintainer approval.Full validation ran on GitHub-hosted Linux because this Windows host's Docker Desktop fails at inference-manager initialization and its native component runner encounters SQLite cleanup
EBUSY. No full native-Windows pass is claimed.Checklist
Additional Notes
AI-assisted implementation, review, and validation. This branch starts independently from
mainand contains only the PR-template change.CI follow-up
The fork-run SonarCloud 401 is tracked in #732 and fixed by #733. The inherited condition admitted fork-owned pushes and fork-local PRs to the canonical SonarCloud project. The dedicated CI fix run now succeeds: all nine executable test/build jobs pass, and SonarCloud is scoped to the canonical repository. That run tests CI fix commit
80a318b; this PR's exact-head verification remains the original run linked above, whose nine executable jobs passed. Upstream Actions still await maintainer approval.