You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue chooser provides no route to Discussions or the private vulnerability-reporting policy. Add both contact links and explicitly set blank_issues_enabled: true, preserving the current availability of blank issues.
Add .github/ISSUE_TEMPLATE/config.yml with Discussions and SECURITY.md's reporting-section links.
Put the private-reporting warning in the security contact's name/description.
Validate the YAML with the existing parser and guard its destinations, labels, blank-issue setting, and security-policy anchor.
Testing
bun run test:unit -t 'issue template contacts': 0 passed / 2 failed before the configuration existed, 2 passed / 0 failed after. Verified that Discussions is enabled upstream and that SECURITY.md contains the linked reporting heading and private-disclosure guidance. The GitHub-hosted chooser will use this configuration after it lands on the default branch.
Full Linux validation used the repository's unchanged CI workflow on submitted commit 9939e20f7025596b26e1df9999050b65308872ce: run and logs.
bun run test:coverage: 14,715 tests passed, all 392 core test files and 34 component isolation groups passed.
bun run coverage:check: 46,324 / 46,324 lines (100%).
Format, lint, typecheck, knip, README/chart/channel/security drift guards, application/library builds, package type-resolution checks, Helm lint, and Go launcher checks passed.
The fork run's overall status is red solely because SonarCloud Analysis lacks the upstream token/project access. All test/build jobs passed. CLAUDE.md explicitly excludes SonarCloud from required checks, and the upstream workflow skips it for fork PRs. Upstream required workflows still need normal maintainer approval.
Full validation ran on GitHub-hosted Linux: this Windows host cannot run the container-based checks because Docker Desktop fails at inference-manager initialization, and its native full component runner encounters SQLite cleanup EBUSY. No complete native-Windows pass is claimed.
Checklist
Issue acceptance criteria checked; actual validation results recorded above.
Full tests and the 100% line-coverage gate passed on the submitted commit.
Diff reviewed; no database-provider changes requiring the provider triad.
Additional Notes
AI-assisted implementation, review, and validation. This branch starts independently from main and contains only this issue's change.
CI follow-up
The fork-run SonarCloud 401 is tracked in #732 and fixed by #733. The inherited condition admitted fork-owned pushes and fork-local PRs to the canonical SonarCloud project. The dedicated CI fix run now succeeds: all nine executable test/build jobs pass, and SonarCloud is scoped to the canonical repository. That run tests CI fix commit 80a318b; this PR's exact-head verification remains the original run linked above, whose nine executable jobs passed. Upstream Actions still await maintainer approval.
Checked against #682. All three "Done when" items hold, including the third: the body states blank_issues_enabled: true and says it preserves today's behaviour, which is the right call for a change like this. Discussions is enabled on the repository, and SECURITY.md:17 is ## Reporting a Vulnerability, so the #reporting-a-vulnerability fragment resolves exactly. The issue did not ask for a test at all; writing a guard for a config file nothing else reads was your own call, and it is the right instinct.
One thing to tighten, because the PR body claims it and it does not quite hold. The anchor check is toContain("## Reporting a Vulnerability"), a prefix match, so renaming the heading to ## Reporting a Vulnerability (private) breaks the fragment while the guard stays green. I ran exactly that: 2 pass, 0 fail. Deriving the fragment from the URL and comparing it against the slugified heading, or asserting the whole heading line, closes it.
The E2E red you saw was not yours. e2e/base-path.spec.ts raced a session-gated health probe against a navigation; I re-ran the job and it is green.
Merging shortly. If you push the anchor tightening first, I will take it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue chooser provides no route to Discussions or the private vulnerability-reporting policy. Add both contact links and explicitly set
blank_issues_enabled: true, preserving the current availability of blank issues.Type of Change
Related Issue
Closes #682
Changes Made
.github/ISSUE_TEMPLATE/config.ymlwith Discussions and SECURITY.md's reporting-section links.Testing
bun run test:unit -t 'issue template contacts': 0 passed / 2 failed before the configuration existed, 2 passed / 0 failed after. Verified that Discussions is enabled upstream and that SECURITY.md contains the linked reporting heading and private-disclosure guidance. The GitHub-hosted chooser will use this configuration after it lands on the default branch.Full Linux validation used the repository's unchanged CI workflow on submitted commit
9939e20f7025596b26e1df9999050b65308872ce: run and logs.bun run test:coverage: 14,715 tests passed, all 392 core test files and 34 component isolation groups passed.bun run coverage:check: 46,324 / 46,324 lines (100%).The fork run's overall status is red solely because SonarCloud Analysis lacks the upstream token/project access. All test/build jobs passed. CLAUDE.md explicitly excludes SonarCloud from required checks, and the upstream workflow skips it for fork PRs. Upstream required workflows still need normal maintainer approval.
Full validation ran on GitHub-hosted Linux: this Windows host cannot run the container-based checks because Docker Desktop fails at inference-manager initialization, and its native full component runner encounters SQLite cleanup
EBUSY. No complete native-Windows pass is claimed.Checklist
Additional Notes
AI-assisted implementation, review, and validation. This branch starts independently from
mainand contains only this issue's change.CI follow-up
The fork-run SonarCloud 401 is tracked in #732 and fixed by #733. The inherited condition admitted fork-owned pushes and fork-local PRs to the canonical SonarCloud project. The dedicated CI fix run now succeeds: all nine executable test/build jobs pass, and SonarCloud is scoped to the canonical repository. That run tests CI fix commit
80a318b; this PR's exact-head verification remains the original run linked above, whose nine executable jobs passed. Upstream Actions still await maintainer approval.