Skip to content

fix: describe the full database scope in page metadata - #728

Merged
cevheri merged 1 commit into
libredb:mainfrom
2160039878-cyber:fix/meta-description-675
Sep 9, 2026
Merged

fix: describe the full database scope in page metadata#728
cevheri merged 1 commit into
libredb:mainfrom
2160039878-cyber:fix/meta-description-675

Conversation

@2160039878-cyber

@2160039878-cyber 2160039878-cyber commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

The page description lists only four engines and undersells the product's scope. Replace it with a 158-character search snippet that describes the self-hosted SQL/NoSQL IDE without depending on a fixed engine count.

Type of Change

  • Bug fix
  • Test addition or update

Related Issue

Closes #675

Also addresses the duplicate report in #678 with the same change.

Changes Made

Updated the existing RootLayout metadata test before changing the description. bun run test:components --pass-with-no-tests -t 'RootLayout' went from 8 passed / 1 failed (old description length: 72) to 9 passed / 0 failed. The test checks the requested 150-160 character length and the broader, count-independent description. --pass-with-no-tests is used only for this targeted local run because the unchanged isolation runner also invokes groups with no matching test names; the full CI coverage run is unfiltered. The same defect is also reported in #678; this is one shared fix.

Testing

  • Local: bun run test:components --pass-with-no-tests -t 'RootLayout': 8 passed / 1 failed before the fix, then 9 passed / 0 failed. The isolation runner uses the flag only to allow groups without a matching test name.
  • Linux CI on the exact PR commit 9effd8f: 14,713 tests passed, all 391 isolated core files and 34 component groups passed; 46325/46325 lines covered (100%). Ran the unfiltered bun run test:coverage and bun run coverage:check scripts.
  • The same run passed formatting, lint, typecheck, knip, README/chart/channel/security guards, application and library builds, Helm lint, and Node 24/26 engine smoke tests.
  • Playwright: 65 passed / 1 flaky (passed on retry) / 6 skipped under the existing configuration, plus 1 subpath, 1 PostgreSQL functional smoke, 3 tarball, and 3 npx tests passed.
  • Secret Scan passed after fetching all fork branch history, including this commit; no leaks found.

I did not complete bun run test / full coverage, the Helm checks, and E2E locally on Windows: the existing SQLite cleanup hits EBUSY, and Docker Desktop is unavailable. The unchanged upstream workflow ran the complete coverage/test layers and the other checks above on Linux instead. SonarCloud is the sole failed job in that fork run: access to the upstream project returns 401 / Not authorized or project not found. Upstream CI already skips SonarCloud for external fork PRs; no workflow or coverage gate was changed.

Test Environment

LibreDB Studio 0.15.0; Windows local / Ubuntu CI; Bun 1.4.2; Node 24 (plus Node 26 smoke); Chromium and WebKit; PostgreSQL functional smoke.

Checklist

  • Claimed the linked issue before editing; branch starts from main.
  • Reviewed the diff and followed the existing style.
  • Updated the existing regression test and verified failure before the fix.
  • All executable test/build jobs pass on the exact commit in Linux CI.

Additional Notes

AI-assisted implementation and validation using Codex, disclosed in the issue claim. Only page metadata and its existing test change. No provider code changes, so the provider code/doc/test triad is not applicable. No dependent changes or screenshots are needed.

CI follow-up

The fork-run SonarCloud 401 is tracked in #732 and fixed by #733. The inherited condition admitted fork-owned pushes and fork-local PRs to the canonical SonarCloud project. The dedicated CI fix run now succeeds: all nine executable test/build jobs pass, and SonarCloud is scoped to the canonical repository. That run tests CI fix commit 80a318b; this PR's exact-head verification remains the original run linked above, whose nine executable jobs passed. Upstream Actions still await maintainer approval.

@cevheri cevheri added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cevheri

cevheri commented Sep 9, 2026

Copy link
Copy Markdown
Member

Checked against #675, and #678, the duplicate it also closes. Both "Done when" items hold: no count anywhere in the sentence, and the snippet is 158 characters, inside the 150 to 160 window.

The strongest part is the test. expect(description).not.toMatch(/\d/) pins the actual invariant, which is that the sentence must not depend on a number, so the next provider cannot make it wrong again. That is worth more than asserting the new string, and it is what the issue was really about. I also checked that no copy of the old sentence survives anywhere else in the tree, so nothing was left behind to drift.

Two notes, neither blocking. The length assertion turns the issue's "roughly 150 to 160" into a hard boundary, and together with toContain("and more") and toContain("SQL and NoSQL") it makes any future rewording a test edit too; the digit guard is the one carrying the real weight. And "SQL IDE ... support for SQL and NoSQL engines" reads slightly against itself to a skimmer, though it does land the NoSQL point that "SQL IDE" alone would hide.

Merging shortly.

@cevheri
cevheri merged commit ffba724 into libredb:main Sep 9, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root page's meta description still names four engines out of sixteen

2 participants