docs: correct the external-engine count and source - #730
Conversation
|
Checked against #667. All three editable items hold: no I derived the numbers rather than trusting the sentence. I also checked the edit costs an agent nothing. One thing that is ours and not yours: "sixteen" is still a hand-written count, so the seventeenth external engine will make this line wrong again with a different word. It now agrees with every other file in the tree that spells the count by hand, and agreeing is worth more here than being uniquely clever, so this is right as it stands. Closing the class means a guard, and I am tracking that separately. Merging shortly. |
Description
The project overview counts the embedded LibreDB store as an external engine. State sixteen external engines plus the embedded store and point at
EXTERNAL_DATABASE_TYPESin compatibility.ts for the published list.Type of Change
Related Issue
Closes #667
Changes Made
Checked the sixteen-entry external list and the EXTERNAL record's single false entry (
libredb). The overview no longer says17 engines, uses the correct source pointer, and retainsnever a prose enumeration.bun run readme:checkpassed. Documentation only; the issue explicitly requires no new test.Testing
bun run readme:checkpassed.3db1f4c: 14,713 tests passed, all 391 isolated core files and 34 component groups passed; 46324/46324 lines covered (100%). Ran the unfilteredbun run test:coverageandbun run coverage:checkscripts.I did not complete
bun run test/ full coverage, the Helm checks, and E2E locally on Windows: the existing SQLite cleanup hitsEBUSY, and Docker Desktop is unavailable. The unchanged upstream workflow ran the complete coverage/test layers and the other checks above on Linux instead. SonarCloud is the sole failed job in that fork run: access to the upstream project returns 401 / Not authorized or project not found. Upstream CI already skips SonarCloud for external fork PRs; no workflow or coverage gate was changed.Test Environment
LibreDB Studio 0.15.0; Windows local / Ubuntu CI; Bun 1.4.2; Node 24 (plus Node 26 smoke); Chromium and WebKit; PostgreSQL functional smoke.
Checklist
main.Additional Notes
AI-assisted implementation and validation using Codex, disclosed in the issue claim. Only documentation changes. No provider code changes, so the provider code/doc/test triad is not applicable. No dependent changes or screenshots are needed.
CI follow-up
The fork-run SonarCloud 401 is tracked in #732 and fixed by #733. The inherited condition admitted fork-owned pushes and fork-local PRs to the canonical SonarCloud project. The dedicated CI fix run now succeeds: all nine executable test/build jobs pass, and SonarCloud is scoped to the canonical repository. That run tests CI fix commit
80a318b; this PR's exact-head verification remains the original run linked above, whose nine executable jobs passed. Upstream Actions still await maintainer approval.