feat(connections): persist custom sidebar ordering - #768
Open
2160039878-cyber wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saved connections can now be dragged into a custom sidebar order using a dedicated handle. The same handle supports Alt+Up / Alt+Down, keeps keyboard focus after moving, and describes both interactions to assistive technology.
Closes #748.
Changes Made
Testing
bun run test:components --pass-with-no-tests -t 'ConnectionsList': 17 passed through the project's isolated component groups. Covers drag, keyboard controls/focus, remount persistence, invalid preferences, external/cancelled drops, cross-tab updates, storage failure and existing connection actions.format,lint,typecheck,knip,readme:check,chart:check,channels:showcase:check,security:check,build,build:lib,attw.8947de38448016a637d974a9f50590c4ea574209.dragstart, preventeddragover,dropanddragend, stored the new ID order, kept Development active and retained focus on the dragged handle. Reload preserved the order. The in-app browser tool's earlier attempt had not delivered adrop; the Edge smoke completed that missing validation. This used a synthetic component fixture, not a live database.bun run test, coverage and app E2E were not run: this Windows host lacks Helm/chart dependencies and working Docker; existing SQLite cleanup also encounters Windows file locks. CI must verify the full suite and 100% line coverage.Environment: Windows, Node.js 24.18.1, Bun 1.4.2.
Checklist
Additional Notes
AI-assisted implementation and validation using Codex. Order is a browser preference, not a cross-device server-synced setting. No dependency, connection-schema or server-storage changes.