fix(oracle): load large schemas on demand - #771
Open
2160039878-cyber wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Oracle connections with tens of thousands of tables currently read every column, constraint and index on connect and after DDL. This change loads the owner-scoped table inventory first and reads one table's details when requested. The explorer and command palette also bound their rendered table rows, so the inventory itself does not mount tens of thousands of controls.
Closes #765.
Type of Change
Changes Made
getSchemaList()reads onlyALL_TABLESnames and estimated row counts. Inventory entries explicitly carrydetailsLoaded: false; empty columns are not treated as a completed read.getTableSchema(name)applies owner and table binds to each of the existing five catalog queries. The existing fullgetSchema()remains available. AuthenticatedPOST /api/db/schema?table=...returns a one-element array, with 400 for an empty name and 404 for an absent/invisible table; providers without a single-table reader retain a full-reader fallback.onSchemaListFetchandonTableSchemaFetch; the requiredonSchemaFetchstill supplies a complete schema.Testing
format,lint,typecheck,knip,readme:check,chart:check,channels:showcase:check,security:check,build,build:lib,attw. Builds used clean commitc44c5f07b416ae637f0e5b30366b6fc078c67391.30eaa32277f79a0b0e4024a6bed435e63052dfa7: 20 checks succeeded and 2 conditional checks skipped. The full suite, 100% line-coverage gate, browser E2E, PostgreSQL functional smoke, Node 24/26 engine smoke and channel E2E passed.Environment: Windows, Node.js 24.18.1, Bun 1.4.2, Microsoft Edge. Oracle catalog-query tests use the project's driver mock; no live Oracle 19c/PeopleSoft/NNE environment was available. The browser fixture validates the real UI and hook code with synthetic metadata, not a real Oracle server.
Checklist
30eaa32277f79a0b0e4024a6bed435e63052dfa7: 20 SUCCESS, 2 SKIPPED).Additional Notes
AI-assisted implementation and validation using Codex. Whole-schema operations and AI workflows that explicitly request the complete schema can still be expensive on a large owner; this change removes that cost from automatic explorer refreshes. Column search/autocomplete grows as tables are loaded. Existing owner-only visibility and row-count estimates are preserved.