-
Notifications
You must be signed in to change notification settings - Fork 614
fix(pi): keep loopback models visible #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n3wr1ch
wants to merge
16
commits into
lidge-jun:dev
Choose a base branch
from
n3wr1ch:fix/pi-loopback-model-visibility
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a8d580b
fix(pi): keep loopback models visible
n3wr1ch 1b2d57b
docs(devlog): add Pi config preview evidence
n3wr1ch aeb97ba
docs(pi): align localized launch guidance
n3wr1ch edad246
docs(pi): qualify generated credential behavior
n3wr1ch ce89ba5
fix(export): omit direct native models
n3wr1ch 75243fd
docs(pi): clarify placeholder wire contract
n3wr1ch eea6939
docs(pi): fix Russian Bearer wording
n3wr1ch 75b0c5b
fix(pi): clarify loopback placeholder guidance
n3wr1ch 8bc35cb
docs(pi): qualify exported model visibility
n3wr1ch eb6d784
docs(pi): describe export summary counts
n3wr1ch a540110
docs(pi): name validated Pi version
n3wr1ch dc118d8
docs(pi): include pre-launch output guidance
n3wr1ch 712816c
fix(export): align file-client model contracts
n3wr1ch f0b1445
fix(export): filter direct combo selectors
n3wr1ch 4994b12
docs(pi): clarify credential and wire names
n3wr1ch 5c03a43
docs(ja): keep Pi product name untranslated
n3wr1ch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the live catalog contains an audio-only model, Pi's serializer drops that row because its schema cannot represent it, but
handleExportCommandcalculates both displayed counts from the pre-serializationmodelsarray. The newly documented “total model count” can therefore exceed the number of models in the JSON, and an omitted audio-only row without a context limit also inflates the degraded count; calculate the summary fromclientConfigthrough the client's existingsummarizefunction.AGENTS.md reference: docs-site/AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0579293. Human CLI counts now come from the client spec’s
summarizeresult over the emitted document. The regression fixture includes an audio-only row that Pi drops and verifies the displayed2 models; 1 omit context limitssummary.