feat(codex): initialize account picker selectors - #1152
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughCodex account selector validation now reserves the ChangesNamespace validation and allocation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks good from my side overall. I didn’t find a code-level blocker. Before I approve, please:
If the rebased diff stays clean and CI passes, I’m good to approve. |
813bd7f to
e73ed2b
Compare
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Rebased and pushed. The current head is I also added JSDoc for the changed namespace helper and the new public policy namespace constant to clear the 66.67% coverage warning. Local checks on this head are green: all four isolated Linux shards (9,636 pass / 11 skip), GUI tests (646 pass), focused selector tests (170 pass), typecheck, privacy scan, GUI build, release-script build, CLI smoke, hygiene, and sponsorship checks. The PR is back Ready with the 4/4 checklist complete. GitHub's fork workflows still need maintainer approval before they can run: CodeRabbit is also re-reviewing the final head. |
Summary
policynamespace and existing slash-qualified routing-profile prefixes during default and append allocationThis is the second slice requested in #1019, following #1096. It intentionally contains only selector initialization and collision foundations. Catalog convergence and management API/dashboard activation remain in later slices.
Part of #425.
Verification
dev@b39eecfcbun run typecheckbun run privacy:scanbun test tests/repo-hygiene.test.tsnode --test .github/scripts/pr-sponsored-surface.test.cjsgit diff --checknative-profile-drain-server.test.ts; that complete file then passed 3/3 in isolationReview readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
Bug Fixes
policyand case-insensitive variants.Documentation