Raise minimum Python version to 3.8 - #2000
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf0520b2b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [project] | ||
| name="lightly" | ||
| requires-python = ">=3.6" | ||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
Update the repository guidance to the new Python floor
After raising this requirement, CLAUDE.md:58-61 still tells AI assistants that the package declares requires-python = ">=3.6" and tests old Python versions. Future assistant-authored changes following that repository guidance may unnecessarily preserve Python 3.6 compatibility or report conflicting requirements, so the guidance should be updated alongside the package metadata.
Useful? React with 👍 / 👎.
cf0520b to
cc4c678
Compare
Closes #1945
Description
This drops Python 3.6 and 3.7 from the package metadata and makes Python 3.8 the minimum throughout the project. The CI matrices, version-specific Make target, Ruff target, Read the Docs configuration, README, and installation guide now agree with
requires-python.Python 3.7 users will need to remain on an earlier Lightly release.
Tests
I built the wheel and confirmed its metadata contains
Requires-Python: >=3.8with classifiers for Python 3.8 through 3.12. I also parsed the edited TOML and YAML files, checked the Python 3.8 Make target, and ran the project-pinned Ruff 0.12.7 checks successfully across all 543 files.Documentation
.rstfiles).Implications / comments / further issues
None beyond the intentional removal of Python 3.6 and 3.7 support tracked in #1945.