Skip to content

Raise minimum Python version to 3.8 - #2000

Open
yashkuceriya wants to merge 1 commit into
lightly-ai:masterfrom
yashkuceriya:raise-python-minimum-3-8
Open

Raise minimum Python version to 3.8#2000
yashkuceriya wants to merge 1 commit into
lightly-ai:masterfrom
yashkuceriya:raise-python-minimum-3-8

Conversation

@yashkuceriya

Copy link
Copy Markdown
Contributor

Closes #1945

Description

  • My change is breaking

This drops Python 3.6 and 3.7 from the package metadata and makes Python 3.8 the minimum throughout the project. The CI matrices, version-specific Make target, Ruff target, Read the Docs configuration, README, and installation guide now agree with requires-python.

Python 3.7 users will need to remain on an earlier Lightly release.

Tests

  • My change is covered by existing tests.
  • My change needs new tests.
  • I have added/adapted the tests accordingly.
  • I have manually tested the change.

I built the wheel and confirmed its metadata contains Requires-Python: >=3.8 with classifiers for Python 3.8 through 3.12. I also parsed the edited TOML and YAML files, checked the Python 3.8 Make target, and ran the project-pinned Ruff 0.12.7 checks successfully across all 543 files.

Documentation

  • I have added docstrings to all public functions/methods.
  • My change requires a change to the documentation (.rst files).
  • I have updated the documentation accordingly.
  • The autodocs update the documentation accordingly.

Implications / comments / further issues

None beyond the intentional removal of Python 3.6 and 3.7 support tracked in #1945.

@gabrielfruet

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf0520b2b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
[project]
name="lightly"
requires-python = ">=3.6"
requires-python = ">=3.8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the repository guidance to the new Python floor

After raising this requirement, CLAUDE.md:58-61 still tells AI assistants that the package declares requires-python = ">=3.6" and tests old Python versions. Future assistant-authored changes following that repository guidance may unnecessarily preserve Python 3.6 compatibility or report conflicting requirements, so the guidance should be updated alongside the package metadata.

Useful? React with 👍 / 👎.

@yashkuceriya
yashkuceriya force-pushed the raise-python-minimum-3-8 branch from cf0520b to cc4c678 Compare July 31, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise minimum supported Python version to 3.8

2 participants