Skip to content

Drop max_inbound_htlc_value_in_flight_percent_of_channel #878

Draft
jkczyz wants to merge 3 commits intolightningdevkit:mainfrom
jkczyz:2026-04-lsp-max-in-flight
Draft

Drop max_inbound_htlc_value_in_flight_percent_of_channel #878
jkczyz wants to merge 3 commits intolightningdevkit:mainfrom
jkczyz:2026-04-lsp-max-in-flight

Conversation

@jkczyz
Copy link
Copy Markdown
Contributor

@jkczyz jkczyz commented Apr 17, 2026

The max_inbound_htlc_value_in_flight_percent_of_channel config setting was used when acting as an LSPS2 service in order to forward the initial payment. However, upstream divided the config setting into two for announced and unannounced channels, the latter defaulting to 100%.

Based on #874.

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 17, 2026

👋 Hi! This PR is now in draft status.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@jkczyz jkczyz marked this pull request as draft April 17, 2026 21:55
@tnull tnull added this to the 0.8 milestone Apr 20, 2026
@jkczyz jkczyz force-pushed the 2026-04-lsp-max-in-flight branch from 2de2b63 to 54b2aa3 Compare April 23, 2026 22:49
jkczyz and others added 3 commits April 23, 2026 17:58
Update to use the new HeaderCache type instead of implementing the
Cache trait, pass BestBlock instead of BlockHash to
synchronize_listeners, and pass HeaderCache by value to SpvClient::new.

Also adapt to BestBlock gaining a previous_blocks field and
ChannelManager deserialization returning BestBlock instead of BlockHash.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
UniFFI cannot represent the fixed-size array that upstream's BestBlock
carries via `previous_blocks`, so NodeStatus.current_best_block was
unusable from Swift, Kotlin, and Python once upstream added that field.
Introduce a small ldk-node BestBlock with just hash and height — the
pieces bindings can handle — and expose it in place of the upstream
type on the public API.

Generated with assistance from Claude Code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The max_inbound_htlc_value_in_flight_percent_of_channel config setting
was used when acting as an LSPS2 service in order to forward the initial
payment. However, upstream divided the config setting into two for
announced and unannounced channels, the latter defaulting to 100%.
@jkczyz jkczyz force-pushed the 2026-04-lsp-max-in-flight branch from 54b2aa3 to e09fd86 Compare April 23, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants