Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mintlify/openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions mintlify/platform-overview/core-concepts/quote-system.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,15 @@ Fees are deducted from the sending amount, so:
- **Amount converted**: $995.00
- **Recipient receives**: €915.40 (at 0.92 rate)

<Note>
Quoted fees may fluctuate between quotes. Some fee components (e.g.
`counterpartyFixedFee` on outgoing transfers, and `gridApiFixedFee` on
incoming transfers) are denominated in the receiving currency, so their
value in the sending currency moves with the FX rate. Always reference the
fees in the latest quote response β€” they are locked only for the lifetime
of that quote.
</Note>

## Best Practices

<AccordionGroup>
Expand Down
4 changes: 2 additions & 2 deletions mintlify/snippets/country-support.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| πŸ‡§πŸ‡· Brazil | BR | `PIX` |
| πŸ‡§πŸ‡¬ Bulgaria | BG | `SEPA` `SEPA Instant` |
| πŸ‡¨πŸ‡² Cameroon | CM | `Bank Transfer` |
| πŸ‡¨πŸ‡΄ Colombia | CO | `Bank Transfer` |
| πŸ‡­πŸ‡· Croatia | HR | `SEPA` `SEPA Instant` |
| πŸ‡¨πŸ‡Ύ Cyprus | CY | `SEPA` `SEPA Instant` |
| πŸ‡¨πŸ‡Ώ Czech Republic | CZ | `SEPA` `SEPA Instant` |
Expand Down Expand Up @@ -85,7 +86,7 @@ Regional Summary
<FeatureCard icon="/images/icons/globe.svg" title="Asia-Pacific" tag="7 countries">
Various instant payment systems
</FeatureCard>
<FeatureCard icon="/images/icons/globe.svg" title="Americas" tag="3 countries">
<FeatureCard icon="/images/icons/globe.svg" title="Americas" tag="4 countries">
PIX, SPEI, ACH, FedNow
</FeatureCard>
</FeatureCardGrid>
Expand All @@ -99,4 +100,3 @@ Grid is rapidly expanding. These corridors are next on our roadmap β€” get in to
| πŸ‡¨πŸ‡¦ Canada | CA |
| πŸ‡¨πŸ‡³ China | CN |
| πŸ‡­πŸ‡° Hong Kong | HK |
| πŸ‡°πŸ‡· South Korea | KR |
8 changes: 8 additions & 0 deletions mintlify/snippets/sending/cross-currency.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/quotes' \
<Warning>
Quote expiration depends on the corridor but is typically ~5 minutes or greater. If expired, create a new quote to get an updated exchange rate.
</Warning>

<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote β€” a new quote for the same
Comment on lines 89 to +97
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Consider <Warning> instead of <Note> for fee fluctuation

The immediately preceding callout uses <Warning> for quote expiration, which simply causes a request to fail. The fee-fluctuation caveat can silently result in a different charge amount β€” a developer who doesn't account for it may show users a price that doesn't match the executed transfer. Per the AGENTS.md component guide, <Warning> is for "Critical information about potential issues"; this arguably qualifies more than expiration does. Consider promoting it to <Warning> for visual parity with the adjacent callout and to signal its importance.

Context Used: mintlify/AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 89-97

Comment:
**Consider `<Warning>` instead of `<Note>` for fee fluctuation**

The immediately preceding callout uses `<Warning>` for quote expiration, which simply causes a request to fail. The fee-fluctuation caveat can silently result in a different charge amount β€” a developer who doesn't account for it may show users a price that doesn't match the executed transfer. Per the AGENTS.md component guide, `<Warning>` is for "Critical information about potential issues"; this arguably qualifies more than expiration does. Consider promoting it to `<Warning>` for visual parity with the adjacent callout and to signal its importance.

**Context Used:** mintlify/AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=51934046-75fb-42d3-9870-f42d61cb60e3))

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

transfer may return a different total.
</Note>
Comment on lines +93 to +99
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The fee-fluctuation note here is nearly identical to the one added in quote-system.mdx, with slightly different wording (this one omits the specific field names counterpartyFixedFee / gridApiFixedFee that the other version mentions). Per the "use snippets instead of duplicating content" rule in CLAUDE.md, this content is a good candidate for a shared snippet β€” e.g. mintlify/snippets/fee-fluctuation-note.mdx β€” so both pages stay in sync automatically.

Suggested change
<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote β€” a new quote for the same
transfer may return a different total.
</Note>
{/* Consider extracting to mintlify/snippets/fee-fluctuation-note.mdx and importing here */}
<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote β€” a new quote for the same
transfer may return a different total.
</Note>

Context Used: CLAUDE.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 93-99

Comment:
The fee-fluctuation note here is nearly identical to the one added in `quote-system.mdx`, with slightly different wording (this one omits the specific field names `counterpartyFixedFee` / `gridApiFixedFee` that the other version mentions). Per the "use snippets instead of duplicating content" rule in CLAUDE.md, this content is a good candidate for a shared snippet β€” e.g. `mintlify/snippets/fee-fluctuation-note.mdx` β€” so both pages stay in sync automatically.

```suggestion
{/* Consider extracting to mintlify/snippets/fee-fluctuation-note.mdx and importing here */}
<Note>
  Quoted fees may fluctuate between quotes. Some underlying fee components
  are denominated in the receiving currency, so their equivalent in the
  sending currency moves with the FX rate. The fee shown in the quote is
  locked only for the lifetime of that quote β€” a new quote for the same
  transfer may return a different total.
</Note>
```

**Context Used:** CLAUDE.md ([source](https://app.greptile.com/review/custom-context?memory=21abe025-35ab-4ae8-a4a1-0071c2ac3b98))

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

</Step>

<Step title="Execute the quote">
Expand Down
6 changes: 3 additions & 3 deletions openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion openapi/components/schemas/quotes/Quote.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ properties:
format: int64
description: >-
The fees associated with the quote in the smallest unit of the sending
currency (eg. cents).
currency (eg. cents). Note: this value may fluctuate between quotes β€”
some underlying fee components are defined in the receiving currency,
so their equivalent in the sending currency moves with the FX rate.
The fees shown here are locked only for the lifetime of this quote.
minimum: 0
example: 10
paymentInstructions:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
description: Details about the rate and fees for an incoming transaction.
description: >-
Details about the rate and fees for an incoming transaction.
Note: `gridApiFixedFee` is denominated in the receiving currency, so its
equivalent value in the sending currency fluctuates with the FX rate.
As a result, the total fee on a subsequent quote for the same transfer
may differ even if the underlying fee structure is unchanged.
type: object
required:
- gridApiMultiplier
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
description: Details about the rate and fees for an outgoing transaction or quote.
description: >-
Details about the rate and fees for an outgoing transaction or quote.
Note: `counterpartyFixedFee` is denominated in the receiving currency, so
its equivalent value in the sending currency fluctuates with the FX rate.
As a result, the total fee on a subsequent quote for the same transfer
may differ even if the underlying fee structure is unchanged.
type: object
required:
- counterpartyMultiplier
Expand Down
Loading