-
Notifications
You must be signed in to change notification settings - Fork 7
docs: sync country coverage with corridor source of truth #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -89,6 +89,14 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/quotes' \ | |||||||||||||||||||||||||||||||
| <Warning> | ||||||||||||||||||||||||||||||||
| Quote expiration depends on the corridor but is typically ~5 minutes or greater. If expired, create a new quote to get an updated exchange rate. | ||||||||||||||||||||||||||||||||
| </Warning> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| <Note> | ||||||||||||||||||||||||||||||||
| Quoted fees may fluctuate between quotes. Some underlying fee components | ||||||||||||||||||||||||||||||||
| are denominated in the receiving currency, so their equivalent in the | ||||||||||||||||||||||||||||||||
| sending currency moves with the FX rate. The fee shown in the quote is | ||||||||||||||||||||||||||||||||
| locked only for the lifetime of that quote β a new quote for the same | ||||||||||||||||||||||||||||||||
| transfer may return a different total. | ||||||||||||||||||||||||||||||||
| </Note> | ||||||||||||||||||||||||||||||||
|
Comment on lines
+93
to
+99
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Context Used: CLAUDE.md (source) Prompt To Fix With AIThis is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 93-99
Comment:
The fee-fluctuation note here is nearly identical to the one added in `quote-system.mdx`, with slightly different wording (this one omits the specific field names `counterpartyFixedFee` / `gridApiFixedFee` that the other version mentions). Per the "use snippets instead of duplicating content" rule in CLAUDE.md, this content is a good candidate for a shared snippet β e.g. `mintlify/snippets/fee-fluctuation-note.mdx` β so both pages stay in sync automatically.
```suggestion
{/* Consider extracting to mintlify/snippets/fee-fluctuation-note.mdx and importing here */}
<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote β a new quote for the same
transfer may return a different total.
</Note>
```
**Context Used:** CLAUDE.md ([source](https://app.greptile.com/review/custom-context?memory=21abe025-35ab-4ae8-a4a1-0071c2ac3b98))
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||||||||||||
| </Step> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| <Step title="Execute the quote"> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Warning>instead of<Note>for fee fluctuationThe immediately preceding callout uses
<Warning>for quote expiration, which simply causes a request to fail. The fee-fluctuation caveat can silently result in a different charge amount β a developer who doesn't account for it may show users a price that doesn't match the executed transfer. Per the AGENTS.md component guide,<Warning>is for "Critical information about potential issues"; this arguably qualifies more than expiration does. Consider promoting it to<Warning>for visual parity with the adjacent callout and to signal its importance.Context Used: mintlify/AGENTS.md (source)
Prompt To Fix With AI