Updated platform embedded wallet confg#475
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript
|
Greptile SummaryThis PR introduces
Confidence Score: 5/5Safe to merge; changes are additive OpenAPI schema additions with no breaking changes to existing fields. All changes are additive — a new optional schema and new optional fields on existing schemas. The bundled YAML files are consistent with the source components. Previous review concerns have been fully addressed, leaving only a minor documentation gap where No files require special attention;
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/config/EmbeddedWalletConfig.yaml | New schema defining per-platform embedded-wallet branding/OTP config; previous review feedback (format hints, otpLength minimum, expirationSeconds maximum) has been addressed, but appName's conditional required constraint is expressed only in prose. |
| openapi/components/schemas/config/PlatformConfigUpdateRequest.yaml | Adds embeddedWalletConfig to the PATCH request body; description correctly describes partial-update semantics (fields omitted are left unchanged). |
| openapi/components/schemas/config/PlatformConfig.yaml | Adds optional embeddedWalletConfig field to the GET response schema; correctly uses $ref with a response-specific description override. |
| openapi/paths/platform/config.yaml | Extends the PATCH example to include embeddedWalletConfig; example is well-formed and consistent with the schema. |
| openapi.yaml | Bundled openapi.yaml updated in sync with source component YAML files; EmbeddedWalletConfig schema and all referencing fields are consistent. |
| mintlify/openapi.yaml | Mintlify-specific bundled spec updated in sync with the main openapi.yaml; no divergence observed. |
Sequence Diagram
sequenceDiagram
participant Client
participant API as PATCH /platform/config
participant Store as Platform Config Store
Client->>API: PATCH embeddedWalletConfig fields
API->>Store: Does embeddedWalletConfig exist?
alt First-time create
Store-->>API: No
Note over API: appName required (server-side only)
API->>Store: Create EmbeddedWalletConfig
else Subsequent update
Store-->>API: Yes
Note over API: Omitted fields left unchanged
API->>Store: Patch EmbeddedWalletConfig
end
Store-->>API: Updated PlatformConfig
API-->>Client: 200 PlatformConfig with embeddedWalletConfig
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
openapi/components/schemas/config/EmbeddedWalletConfig.yaml:7-16
**`appName` conditional requirement not enforced by the schema**
The description states "`appName` is required when creating the configuration for the first time," but `EmbeddedWalletConfig` has no `required` array anywhere. SDK generators and OpenAPI validators will treat `appName` as fully optional, so a client could send `{"embeddedWalletConfig": {}}` on first create, pass schema validation cleanly, and only hit a server error at runtime. Since the constraint depends on server-side state (whether the config already exists) it can't be expressed with a simple `required` list — but if you have separate create/update code paths, consider a dedicated create-only request schema that does mark `appName` as required.
Reviews (4): Last reviewed commit: "Updated platform embedded wallet confg" | Re-trigger Greptile
9c0165d to
e3c4efa
Compare
e3c4efa to
ada6eb6
Compare
ada6eb6 to
f8762b1
Compare
|
@greptile review again |
| behavior for the email sent when a customer authenticates with an | ||
| EMAIL_OTP credential. Omitted fields fall back to platform defaults. | ||
| When creating the configuration for the first time, `appName` is required. |
There was a problem hiding this comment.
what does this mean when we create the platform on signup?
f8762b1 to
c6b1d0b
Compare

No description provided.