Skip to content

docs: fix auth account identifiers#476

Draft
DhruvPareek wants to merge 1 commit into
mainfrom
docs-auth-email-account-ids
Draft

docs: fix auth account identifiers#476
DhruvPareek wants to merge 1 commit into
mainfrom
docs-auth-email-account-ids

Conversation

@DhruvPareek
Copy link
Copy Markdown
Contributor

@DhruvPareek DhruvPareek commented May 19, 2026

Summary

  • Use InternalAccount:<uuid> in Global Accounts auth credential examples.
  • Remove stale email fields from EMAIL_OTP credential creation requests.
  • Clarify that Grid resolves the OTP address from the customer email on file.

Test Plan

  • git diff --check main...HEAD
  • Targeted rg scan for stale EmbeddedWallet:<id>, request-body email fields, and old signed-retry request IDs.

Use InternalAccount IDs in Global Accounts auth examples and remove stale email fields from EMAIL_OTP credential creation. Clarify that Grid resolves the OTP email from the customer email on file.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment May 19, 2026 0:03am

Request Review

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 19, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview May 19, 2026, 12:05 AM

Copy link
Copy Markdown
Contributor Author

DhruvPareek commented May 19, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Greptile Summary

This PR corrects stale account identifier prefixes and request body fields throughout the Global Accounts authentication documentation. All EmbeddedWallet:<uuid> account ID examples are replaced with InternalAccount:<uuid>, the email field is removed from EMAIL_OTP credential creation requests, and prose and sequence diagrams are updated to reflect that Grid resolves the OTP delivery address from the customer record rather than a caller-supplied email.

  • Replaces EmbeddedWallet: with InternalAccount: in every OAUTH and EMAIL_OTP curl example, response snippet, and query parameter across the file.
  • Removes the email field from all EMAIL_OTP registration request bodies (first credential and signed-retry flows) and adds a note explaining that Grid looks up the address from the account's customer record.
  • One stale EmbeddedWallet: occurrence remains inside the JSON-encoded payloadToSign string in the "Add an additional credential" response example (line 588), which was missed because it is embedded within a quoted string literal.

Confidence Score: 3/5

Safe to merge after fixing the missed EmbeddedWallet: inside the payloadToSign string on line 588 — leaving it contradicts every other corrected example in the file and will confuse developers comparing the signed payload they receive against the docs.

The bulk of the renaming is correct and consistent, but one EmbeddedWallet: occurrence was missed inside the JSON-encoded payloadToSign example. Because that string is precisely what Grid returns to the caller during the signed-retry flow, a developer who reads it will see an identifier format that no longer matches the corrected request examples — creating a direct contradiction in the documentation for a security-sensitive operation.

mintlify/snippets/global-accounts/authentication.mdx — specifically the payloadToSign response body in the "Add an additional credential" section (line 588).

Important Files Changed

Filename Overview
mintlify/snippets/global-accounts/authentication.mdx Updates EmbeddedWallet:InternalAccount: across OAUTH and EMAIL_OTP examples, removes the email field from EMAIL_OTP request bodies, and updates sequence diagrams — but one EmbeddedWallet: occurrence remains inside the JSON-encoded payloadToSign string on line 588.

Comments Outside Diff (1)

  1. mintlify/snippets/global-accounts/authentication.mdx, line 588 (link)

    P1 The payloadToSign response example on this line still uses the old EmbeddedWallet: account ID prefix. Every other account ID in this file was updated to InternalAccount:, but this one was missed — it sits inside the JSON-encoded string, making it easy to overlook. A developer following the docs will see EmbeddedWallet: appear in the actual signed payload returned by Grid, which contradicts the corrected examples everywhere else in the file.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: mintlify/snippets/global-accounts/authentication.mdx
    Line: 588
    
    Comment:
    The `payloadToSign` response example on this line still uses the old `EmbeddedWallet:` account ID prefix. Every other account ID in this file was updated to `InternalAccount:`, but this one was missed — it sits inside the JSON-encoded string, making it easy to overlook. A developer following the docs will see `EmbeddedWallet:` appear in the actual signed payload returned by Grid, which contradicts the corrected examples everywhere else in the file.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.

    Fix in Claude Code

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
mintlify/snippets/global-accounts/authentication.mdx:588
The `payloadToSign` response example on this line still uses the old `EmbeddedWallet:` account ID prefix. Every other account ID in this file was updated to `InternalAccount:`, but this one was missed — it sits inside the JSON-encoded string, making it easy to overlook. A developer following the docs will see `EmbeddedWallet:` appear in the actual signed payload returned by Grid, which contradicts the corrected examples everywhere else in the file.

```suggestion
      "payloadToSign": "{\"requestId\":\"7c4a8d09-ca37-4e3e-9e0d-8c2b3e9a1f21\",\"type\":\"EMAIL_OTP\",\"accountId\":\"InternalAccount:019542f5-b3e7-1d02-0000-000000000002\",\"expiresAt\":\"2026-04-08T15:35:00Z\"}",
```

Reviews (1): Last reviewed commit: "docs: fix auth account identifiers" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant