Skip to content

[kyb] add issuing authority to IDs #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcamata merged 1 commit into from
May 19, 2026
Merged

[kyb] add issuing authority to IDs #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions openapi/components/schemas/customers/BeneficialOwnerPersonalInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,7 @@ properties:
type: string
description: Country that issued the identification (ISO 3166-1 alpha-2)
example: US
issuingAuthority:
Copy link
Copy Markdown
Contributor

@wuvictor-95 wuvictor-95 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be required?

Copy link
Copy Markdown
Contributor Author

@gcamata gcamata May 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be in the future (https://lightspark.atlassian.net/browse/AT-5270), but I want to add it to the dashboard first and test while it's still optional

type: string
description: Name of the government agency or organization that issued the identification
example: U.S. Department of State
4 changes: 4 additions & 0 deletions openapi/components/schemas/customers/BeneficialOwnerPersonalInfoUpdate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,7 @@ properties:
type: string
description: Country that issued the identification (ISO 3166-1 alpha-2)
example: US
issuingAuthority:
type: string
description: Name of the government agency or organization that issued the identification
example: U.S. Department of State
4 changes: 4 additions & 0 deletions openapi/components/schemas/customers/PersonalIdentification.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ properties:
type: string
description: Country that issued the identification (ISO 3166-1 alpha-2)
example: US
issuingAuthority:
type: string
description: Name of the government agency or organization that issued the identification
example: U.S. Department of State
Comment on lines +16 to +19
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PersonalIdentification.yaml appears to be unreferenced — searching the entire openapi/ directory (and the bundled openapi.yaml / mintlify/openapi.yaml) returns no $ref pointing to this schema. That means the issuingAuthority field added here won't surface in the generated API spec at all. If this schema is intentionally a "stub" for future use, it's fine to leave it, but the change has no current effect on the API surface. If it was expected to be the canonical definition shared by the beneficial-owner schemas, those schemas would need to reference it via $ref instead of inlining the identification fields.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/customers/PersonalIdentification.yaml
Line: 16-19

Comment:
`PersonalIdentification.yaml` appears to be unreferenced — searching the entire `openapi/` directory (and the bundled `openapi.yaml` / `mintlify/openapi.yaml`) returns no `$ref` pointing to this schema. That means the `issuingAuthority` field added here won't surface in the generated API spec at all. If this schema is intentionally a "stub" for future use, it's fine to leave it, but the change has no current effect on the API surface. If it was expected to be the canonical definition shared by the beneficial-owner schemas, those schemas would need to reference it via `$ref` instead of inlining the identification fields.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

Loading