Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

---

## [Unreleased] — Fix WCAG color-contrast violations for captions and blog filter pill (LS-2934)

### Fixed

- `src/scss/structural/image-captions.scss` (new): image captions (`.wp-element-caption`/`figcaption`) previously rendered WordPress core's unthemed default text colour (`#555555`) against this theme's dark background (`#080808`), a 2.68:1 contrast ratio. Now uses the existing `--text--on-dark-muted` token (10.1:1), applied sitewide.
- `src/scss/structural/taxonomy-filter.scss`: the blog page's category filter pill, in its active/selected state (`.taxonomy-filter-current`), paired light text with its blue background at a 2.92:1 ratio. Swapped to the existing `--text--on-light` token (6.57:1 against the same background), including its hover/focus state.

([#61](https://github.com/lightspeedwp/ls-theme/pull/61))

---

## [Unreleased] — Fix editor validation errors and Icon block attributes on Services patterns (LS-4207)

### Fixed
Expand Down
1 change: 1 addition & 0 deletions assets/css/image-captions.css
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.wp-element-caption,figcaption{color:var(--wp--custom--color--text--on-dark-muted)}
2 changes: 1 addition & 1 deletion assets/css/taxonomy-filter.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ function ls_theme_setup() {
// regardless of which template it's viewed through.
add_editor_style( 'style.css' );
add_editor_style( 'assets/css/animations.css' );
add_editor_style( 'assets/css/image-captions.css' );
add_editor_style( 'assets/css/taxonomy-filter.css' );
add_editor_style( 'assets/css/work-project-card.css' );
add_editor_style( 'assets/css/work-archive-sections.css' );
Expand Down
7 changes: 7 additions & 0 deletions inc/animations.php
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,13 @@ function ls_theme_get_effect_styles( $context = 'front' ) {
'path' => 'assets/css/animations.css',
'contexts' => array( 'front', 'editor' ),
),
// Image captions can appear in any post/page's content, so this loads unconditionally
// rather than being gated to a specific template (LS-2934).
'image-captions' => array(
'handle' => 'ls-theme-image-captions',
'path' => 'assets/css/image-captions.css',
'contexts' => array( 'front', 'editor' ),
Comment thread
brandonmarshal marked this conversation as resolved.
),
// Structural bundles (LS-2615, gated LS-2922): each `condition` reflects verified actual
// usage (grepped against every pattern that references the bundle's CSS classes), not an
// assumed template mapping — some bundles turned out not to be template-exclusive (e.g.
Expand Down
Loading
Loading